Closed Bug 1841982 Opened 10 months ago Closed 10 months ago

Stuttery Audio Playing Live Stream

Categories

(Core :: Audio/Video: Playback, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
117 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 115+ verified
firefox115 + verified
firefox116 + verified
firefox117 + verified

People

(Reporter: jamie, Assigned: padenot)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

When playing back certain live MP3 streams in Firefox 115, the audio is garbled and unlistenable.

In particular, this occurs when Firefox tries to play back a fallback media file from an Icecast streaming server. The implementation in Icecast works in a simple fashion by concatenating MP3 frames but it makes no attempt to remove metadata.

Steps to reproduce:

  1. Play back an Icecast fallback stream - for example: https://uksoutha.streaming.broadcast.radio/firefox_test_fallback
  2. Compare to a reference audio player such as VLC

I've determined this bug was introduced in version 115 - playing back the above stream works correctly in 114. I can reproduce this bug on both macOS and Windows.

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(padenot)
Keywords: regression
Regressed by: 1703812
Assignee: nobody → padenot
Flags: needinfo?(padenot)

Jamie, thanks for the report, and sorry for the bug, I've got a fix, we're probably going to ship this to release asap.

Mayank, thanks for the quick range and triaging!

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6070cd460335
Only mark packets as EOF if the stream size is known in the MP3TrackDemuxer. r=media-playback-reviewers,chunmin
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

The patch landed in nightly and beta is affected.
:padenot, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(padenot)

Comment on attachment 9342575 [details]
Bug 1841982 - Only mark packets as EOF if the stream size is known in the MP3TrackDemuxer. r?#media-playback-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Broken audio rendering on some high profile radio broadcast website
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is just an oversight and the fix is trivial. We're restoring to the behaviour we had in the previous release.
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(padenot)
Attachment #9342575 - Flags: approval-mozilla-release?
Attachment #9342575 - Flags: approval-mozilla-beta?

Paul <padenot@mozilla.com>, thank you for getting this one fixed so fast!

I continue to be amazed at both how carefully engineered and robust audio capture/playback is in Firefox! It's well known in the broadcasting industry etc. that Firefox has the most reliable audio out of any browser :-)

(Moments after my comment, my Nightly picked up today's build and I can confirm that indeed fixed it for me!)

Comment on attachment 9342575 [details]
Bug 1841982 - Only mark packets as EOF if the stream size is known in the MP3TrackDemuxer. r?#media-playback-reviewers

Approved for 116.0b3

Attachment #9342575 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed by dsmith@mozilla.com:
https://hg.mozilla.org/releases/mozilla-beta/rev/bd50e163e8d8
Only mark packets as EOF if the stream size is known in the MP3TrackDemuxer. r=media-playback-reviewers,chunmin,a=dsmith
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified as fixed in our latest Nightly and Beta 116.0b3 builds.

Comment on attachment 9342575 [details]
Bug 1841982 - Only mark packets as EOF if the stream size is known in the MP3TrackDemuxer. r?#media-playback-reviewers

Approved for 115.0.2
Approved for 115.0.2esr

Attachment #9342575 - Flags: approval-mozilla-release?
Attachment #9342575 - Flags: approval-mozilla-release+
Attachment #9342575 - Flags: approval-mozilla-esr115+

This issue is verified as fixed in our latest 115.0.2 and 115.0.2esr builds.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
See Also: → 1843003
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: