1842214 - "WebDriver:ElementSendKeys" doesn't use implicit wait for element to become keyboard-interactable

Status: ASSIGNED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Original report: https://github.com/mozilla/geckodriver/issues/2104

WebDriver:ElementSendKeys has to wait until the element is keyboard interactable:

7.2.Wait in an implementation-specific way up to the session implicit wait timeout for element to become keyboard-interactable.

This is currently not done in Marionette.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Dan]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #0)

Original report: https://github.com/mozilla/geckodriver/issues/2104

WebDriver:ElementSendKeys has to wait until the element is keyboard interactable:

7.2.Wait in an implementation-specific way up to the session implicit wait timeout for element to become keyboard-interactable.

This is currently not done in Marionette.

In this message, you are made reference to the webdriverClickElement in interaction.sys.mjs, which is as to do with click events. And if there is anything to be done there as regards interaction it would be pointer-interactability not keyboard-interactability. I think the function that needs be worked on would be webdriverSendKeysToElement in the same interaction.sys.mjs. The todo for keyboard-interactibility is written there I think. @whimboo can you please confirm if I am in the right track on this.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dan, you are totally right! I indeed added a wrong link to webDriverElementClick instead. So yes, if you are still interested to pick this bug up please get started. In case of questions don't hesitate to reach out to us again. Thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dan, are you still interested to work on this bug? Please let me know because otherwise I would hand it to someone else if there is a request. Thanks.

Comment 5

[Dan]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #4)

Dan, are you still interested to work on this bug? Please let me know because otherwise I would hand it to someone else if there is a request. Thanks.

Yeah, I am still interested in working on it. I was away. I will update soon.

Comment 6

[Dan]

Attachment: Bug 1842214 - "WebDriver:ElementSendKeys" doesn't use implicit wait for element to become keyboard-interactable. r?whimboo

Comment 7

[Phabricator Automation]

Comment on attachment 9423894 [details]
Bug 1842214 - "WebDriver:ElementSendKeys" doesn't use implicit wait for element to become keyboard-interactable. r?whimboo

Revision D221662 was moved to bug 1842213. Setting attachment 9423894 [details] to obsolete.