1842301 - [wpt-sync] Sync PR 40923 - view-transitions: Ensure root element generates group animations.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40923 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40923
Details from upstream follow.

Khushal Sagar <[e-mail]> wrote:

view-transitions: Ensure root element generates group animations.

This change aligns the implementation for tracking state and generating
styles for the root element with sub-elements. This aligns well with the
spec and ensures the behaviour for root transitions stays consistent
with element transitions.

Specifically, we now generate animations for the group pseudo
corresponding to the root. This means we now have a no-op animation for
the root. While this aligns with the spec, it should be optimized going
forward.

R=[e-mail]

Bug:1454863, 1457298
Change-Id: I3ea09dd0f021675875f2aabf911421e8810f8465
Reviewed-on: https://chromium-review.googlesource.com/4668328
WPT-Export-Revision: 2dde2ef002cb3eaf2affb9a40ef34e9e0fd25f88

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=60369be3e13c6deffdd7180fc0c45ed4c8dcbbe9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 1
ERROR : 1

Chrome

OK : 1
FAIL : 1

Safari

TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-view-transitions/group-animation-for-root-transition.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • incorrect UA animations for root transition: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6186c58f5624
[wpt PR 40923] - view-transitions: Ensure root element generates group animations., a=testonly
https://hg.mozilla.org/integration/autoland/rev/c5530b137a06
[wpt PR 40923] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6186c58f5624
https://hg.mozilla.org/mozilla-central/rev/c5530b137a06