1842302 - [wpt-sync] Sync PR 40924 - Implement state transition for AudioContext.setSinkId

Status: RESOLVED FIXED

(Core :: Web Audio, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40924 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40924
Details from upstream follow.

Hongchan Choi <[e-mail]> wrote:

Implement state transition for AudioContext.setSinkId

This CL updates the implementation of AudioContext to follow the
spec algorithm of the state transition from setSinkid() method.

https://webaudio.github.io/web-audio-api/#dom-audiocontext-setsinkid-domstring-or-audiosinkoptions-sinkid

The relevant web test is also updated and the failing expectation file
is removed.

Bug: 1439947
Change-Id: I56d8c89272d66b08502203a846c65231a72e8549
Reviewed-on: https://chromium-review.googlesource.com/4670272
WPT-Export-Revision: a49676f3af0002839f5963f557c6ad4a72e6f3b1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f799bc36f645043eeedf70e1f1e4b014ea9bf479

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

ERROR : 1
NOTRUN : 2

Chrome

PASS : 1
TIMEOUT: 2

Safari

ERROR : 1
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webaudio/the-audio-api/the-audiocontext-interface/audiocontext-sinkid-state-change.https.html [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • Calling setSinkId() on a suspended AudioContext should fire only sink change events.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
  • Calling setSinkId() on a running AudioContext should fire both state and sink change events.: NOTRUN (Chrome: TIMEOUT, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/143a4453f3fa
[wpt PR 40924] - Implement state transition for AudioContext.setSinkId, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/143a4453f3fa