1842306 - [wpt-sync] Sync PR 40926 - [anchor-position] Properly implement CSSOM API classes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40926 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40926
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[anchor-position] Properly implement CSSOM API classes

This patch adds proper implementation of the CSSPositionFallbackRule
and CSSTryRule API as specified [1]:

1. It reimplements CSSPositionFallbackRule as a subclass of
   CSSGroupingRule, and StyleRulePositionFallback as a subclass
   of StyleRuleGroup.

2. It adds some code to CSSGroupingRule.insertRule() to make sure
   the function only adds @try rules into CSSPositionFallbackRule.

3. Since CSSStyleRule.style.setProperty() can add disallowed
   properties into a @try block [2], this patch also adds filtering
   into the style cascade to make sure when applying the style from
   a @try rule, only allowed properties' values are applied.

This patch also manually adds the IDL of the APIs into wpt so that we
can add idlharness test without waiting for the IDL auto roller.

[1] https://drafts.csswg.org/css-anchor-position-1/#interfaces
[2] https://github.com/w3c/csswg-drafts/issues/9042

Bug: 1309178
Change-Id: Ib7700605a9968a3547fbe99197c882e8aa6caaea

Reviewed-on: https://chromium-review.googlesource.com/4668131
WPT-Export-Revision: de3a0d86da08ef3c15ed814437ecb374f6d50727

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d639705959b0001b1b87ed173c8612609855338

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 25 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 25

Chrome

OK : 2
PASS: 20
FAIL: 8

Safari

OK : 2
PASS: 2
FAIL: 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/at-position-fallback-cssom.html [wpt.fyi]
  • CSSPositionFallbackRule and CSSTryRule attribute values: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSPositionFallbackRule.insertRule can insert @try rules only: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSTryRule.style.setProperty setting allowed and disallowed properties: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/idlharness.html [wpt.fyi]
  • CSSPositionFallbackRule interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSPositionFallbackRule interface object length: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSPositionFallbackRule interface object name: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSPositionFallbackRule interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSPositionFallbackRule interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSPositionFallbackRule interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSPositionFallbackRule interface: attribute name: FAIL (Chrome: PASS, Safari: FAIL)
  • Stringification of positionFallback: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSPositionFallbackRule interface: positionFallback must inherit property "name" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface object length: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface object name: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: attribute style: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSTryRule must be primary interface of try1: FAIL (Chrome: PASS, Safari: FAIL)
  • Stringification of try1: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: try1 must inherit property "style" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
  • CSSTryRule must be primary interface of try2: FAIL (Chrome: PASS, Safari: FAIL)
  • Stringification of try2: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSTryRule interface: try2 must inherit property "style" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc2512898d97
[wpt PR 40926] - [anchor-position] Properly implement CSSOM API classes, a=testonly
https://hg.mozilla.org/integration/autoland/rev/abfc7d09019b
[wpt PR 40926] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dc2512898d97
https://hg.mozilla.org/mozilla-central/rev/abfc7d09019b