Closed Bug 1842309 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 40929 - [anchor-position] Make 'anchor-scroll' internal

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40929 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40929
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[anchor-position] Make 'anchor-scroll' internal

See https://github.com/w3c/csswg-drafts/issues/8675 for context.

This patch:

  1. Changes the implementation to longer expose anchor-scroll as a
    CSS property, but use the target of anchor-default for scrolling
    purposes

  2. Coverts tests and UA style to stop using anchor-scroll. The usage
    is either simply removed if there's already a default anchor, or
    changed to use anchor-default otherwise. The cases that assume
    different anchor-scroll and anchor-default targets are removed
    since they will no longer be a possible.

To minimize diff, this patch focuses on the implementation change.
A follow up patch will convert all in-code documentations and rename
existing classes/functions to stop referring to the functionality as
"anchor-scroll", and hence, stop the naming confusion.

Bug: 1463085
Change-Id: I3cb2000de67b2b81b4edf8b9a1303de682946232
Reviewed-on: https://chromium-review.googlesource.com/4662290
WPT-Export-Revision: cd6a193d577fea5a41456dbe6dc4f3ef9873a2f8

PR 40929 applied with additional changes from upstream: 4733ae5e5590fec37db69778aaaf5ef4ce84ee61
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 41 tests

Status Summary

Firefox

OK : 16
PASS : 6
FAIL : 68[GitHub] 69[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt]
TIMEOUT: 1

Chrome

OK : 16
PASS : 73
FAIL : 2

Safari

OK : 16
PASS : 6
FAIL : 69

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/849e1d77375f
[wpt PR 40929] - [anchor-position] Make 'anchor-scroll' internal, a=testonly
https://hg.mozilla.org/integration/autoland/rev/780149048992
[wpt PR 40929] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/849e1d77375f
https://hg.mozilla.org/mozilla-central/rev/780149048992

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.