1842313 - [wpt-sync] Sync PR 40931 - [layout] Fix relayout boundary logic.

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40931 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40931
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Fix relayout boundary logic.

\<div id="a">
\<div id="b">
\<div id="inner">\</div>
\</div>
\</div>

Where "a" and "b" are potential relayout boundary targets.

Previously it was possible to have the following invalidation logic:

1. "inner" changes - and invalidates layout up to "b".
2. "b" gets added as a relayout boundary.
3. "b" changes its own style - and invalidates layout up to "a".
   (note this may disqualify "b" as a relayout boundary).
4. Layout starts at "b" but potentially with the wrong constraints.
5. Layout starts at "a", but doesn't revisit "b" as it is layout clean.

This caused various types of DCHECKs and potentially incorrect layouts.

This patch ensures that we don't relayout as a root if we are marked as
needing layout by our own style.

Fixed: 1462742
Fixed: 1454351
Change-Id: I0ff0818ac85844acf5f6ec88ad73db83147ee01e
Reviewed-on: https://chromium-review.googlesource.com/4671128
WPT-Export-Revision: 4ef588bb865d00d3ba519948dc4701c4908f11c9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f535887b68dc260c5a245440ebb25e9b54addd7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

PASS: 1
FAIL: 2

Safari

PASS: 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4305258e4264
[wpt PR 40931] - [layout] Fix relayout boundary logic., a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4305258e4264