1842455 - Remove dom.webnotifications.allowcrossoriginiframe pref

Status: RESOLVED FIXED

(Core :: DOM: Notifications, task)

Description

[Gregory Pappas [:gregp]]

Notification permission requests from cross-origin iframes have been disabled for about 4 years now (bug 1560741). No regressions have been reported since then, so we should be able to remove this pref.

Comment 1

[Igor [:ExplodingJoysticks]]

Attachment: Bug 1842455 - Remove the dom.webnotifications.allowcrossoriginiframe pref r?saschanaz

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1842455 - Part 1: Extract notification permission test into WPT r=#dom-core

Removing the pref breaks the test, and while fixing it is possible, it involves remote browser. So I decided to do WPT instead as testing web API in chrome test is weird after all.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9135a449dc8b
https://hg.mozilla.org/integration/autoland/rev/a4d8a49b5ce8
Part 1: Extract notification permission test into WPT r=dom-core-reviewers,smaug

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a4d8a49b5ce8

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a4d8a49b5ce8

Comment 6

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

oopsie not yet

Comment 7

[Igor [:ExplodingJoysticks]]

Attachment: Bug 1842455 - Remove the dom.webnotifications.allowcrossoriginiframe pref r?saschanaz

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/764cf7b2dbd3
https://hg.mozilla.org/integration/autoland/rev/d759abc98259
Remove the dom.webnotifications.allowcrossoriginiframe pref r=saschanaz

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d759abc98259