Closed Bug 1842463 Opened 2 years ago Closed 2 years ago

Cleanup declarations in BytecodeCompilation.h and BytecodeCompiler.h

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Having both BytecodeCompilation.h and BytecodeCompiler.h is often confusing.
It's better removing BytecodeCompilation.h and moving some to BytecodeCompiler.h, or a new header with clearer name.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #9343017 - Attachment description: Bug 1842463 - Part 1: Move IsIdentifier* to util/Identifier.{cpp,h}. r=bthrall → Bug 1842463 - Part 1: Move IsIdentifier* to util/Identifier.{cpp,h}. r=bthrall!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/411b1267d7cf Part 1: Move IsIdentifier* to util/Identifier.{cpp,h}. r=bthrall https://hg.mozilla.org/integration/autoland/rev/09980c60689e Part 2: Move IsKeyword to frontend/TokenStream.{cpp,h}. r=bthrall https://hg.mozilla.org/integration/autoland/rev/185a0314ed2e Part 3: Make FireOnNewScript file-static. r=bthrall https://hg.mozilla.org/integration/autoland/rev/75705edef238 Part 4: Move CanLazilyParse to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/45d206bbb296 Part 5: Move DelazifyCanonicalScriptedFunction to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/2975dcc9aab5 Part 6: Move CompileGlobalScriptTo{,Extensible}Stencil to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/3d1472bc12d5 Part 7: Remove unused frontend::PrepareForInstantiate. r=bthrall https://hg.mozilla.org/integration/autoland/rev/ff723d870997 Part 8: Move InstantiateStencils to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/64036170d5dc Part 9: Move CompileGlobalScript to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/0dd9eab997f7 Part 10: Move CompileEvallScript to frontend/BytecodeCompiler.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/9b888730769e Part 11: Remove frontend/BytecodeCompilation.h. r=bthrall https://hg.mozilla.org/integration/autoland/rev/323e5b655b19 Part 12: Cleanup include and forward declarations. r=bthrall
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: