1842463 - Cleanup declarations in BytecodeCompilation.h and BytecodeCompiler.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Having both BytecodeCompilation.h and BytecodeCompiler.h is often confusing.
It's better removing BytecodeCompilation.h and moving some to BytecodeCompiler.h, or a new header with clearer name.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 1: Move IsIdentifier* to util/Identifier.{cpp,h}. r=bthrall!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 2: Move IsKeyword to frontend/TokenStream.{cpp,h}. r=bthrall

Depends on D183136

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 3: Make FireOnNewScript file-static. r=bthrall

Depends on D183137

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 4: Move CanLazilyParse to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183138

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 5: Move DelazifyCanonicalScriptedFunction to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183139

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 6: Move CompileGlobalScriptTo{,Extensible}Stencil to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183140

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 7: Remove unused frontend::PrepareForInstantiate. r=bthrall

Depends on D183141

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 8: Move InstantiateStencils to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183142

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 9: Move CompileGlobalScript to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183143

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 10: Move CompileEvallScript to frontend/BytecodeCompiler.h. r=bthrall

Depends on D183144

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 11: Remove frontend/BytecodeCompilation.h. r=bthrall

Depends on D183145

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1842463 - Part 12: Cleanup include and forward declarations. r=bthrall

Depends on D183146

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/411b1267d7cf
Part 1: Move IsIdentifier* to util/Identifier.{cpp,h}. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/09980c60689e
Part 2: Move IsKeyword to frontend/TokenStream.{cpp,h}. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/185a0314ed2e
Part 3: Make FireOnNewScript file-static. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/75705edef238
Part 4: Move CanLazilyParse to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/45d206bbb296
Part 5: Move DelazifyCanonicalScriptedFunction to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/2975dcc9aab5
Part 6: Move CompileGlobalScriptTo{,Extensible}Stencil to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/3d1472bc12d5
Part 7: Remove unused frontend::PrepareForInstantiate. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/ff723d870997
Part 8: Move InstantiateStencils to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/64036170d5dc
Part 9: Move CompileGlobalScript to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/0dd9eab997f7
Part 10: Move CompileEvallScript to frontend/BytecodeCompiler.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/9b888730769e
Part 11: Remove frontend/BytecodeCompilation.h. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/323e5b655b19
Part 12: Cleanup include and forward declarations. r=bthrall

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/411b1267d7cf
https://hg.mozilla.org/mozilla-central/rev/09980c60689e
https://hg.mozilla.org/mozilla-central/rev/185a0314ed2e
https://hg.mozilla.org/mozilla-central/rev/75705edef238
https://hg.mozilla.org/mozilla-central/rev/45d206bbb296
https://hg.mozilla.org/mozilla-central/rev/2975dcc9aab5
https://hg.mozilla.org/mozilla-central/rev/3d1472bc12d5
https://hg.mozilla.org/mozilla-central/rev/ff723d870997
https://hg.mozilla.org/mozilla-central/rev/64036170d5dc
https://hg.mozilla.org/mozilla-central/rev/0dd9eab997f7
https://hg.mozilla.org/mozilla-central/rev/9b888730769e
https://hg.mozilla.org/mozilla-central/rev/323e5b655b19