1842473 - test_tree_scroll.xhtml depends on load event timing

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

In bug 1824886 (which makes firing the load event sooner) I tried to tweak it to preserve the previous behavior. Without that there were failures like:

• https://treeherder.mozilla.org/logviewer?job_id=422048293&repo=autoland&lineNumber=5092

Daisuke, I saw the test already used onload="setTimeout(...)", do you know why that was needed?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

(See question above, sorry)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'll try to investigate tomorrow

Comment 3

[Daisuke Akatsuka (:daisuke)]

HI Emilio!
Unfortunately, I’m not sure exactly. As other tests in the same directory have executed their tests like that, I introduced the same way.
https://searchfox.org/mozilla-central/search?q=onload%3D"setTimeout(&path=content%2Ftests%2Fchrome%2F&case=false&regexp=false

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1842473 - Fix coordinate space of tree scroll test. r=hiro,botond,daisuke

These APIs take device pixels, not CSS pixels.

I'm not sure this will be enough to fix the test but this at least
allows the test to pass on the macOS machine I have, and it's trivially
correct.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/892c0dac0180
Fix coordinate space of tree scroll test. r=hiro

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Ok this was a bit more annoying. It seems like test_preferences.xhtml left a stray modal window and made mousemove events not work on macOS...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1842473 - Make test_preferences not leave a stray modal window on macOS.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f802bfdd640
Make test_preferences not leave a stray modal window on macOS.

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/892c0dac0180
https://hg.mozilla.org/mozilla-central/rev/7f802bfdd640