1842497 - Unship d3dcompiler_47.dll and Universal CRT DLLs

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Masatoshi Kimura [:emk]]

Windows 8.1+ has d3dcompiler_47.dll.

Although not all Windows 8.1 machines have UCRT, win2012 builders have UCRT because toolchains require UCRT. We don't have to care about all Windows 8.1 machines as long as Firefox works with automation.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1842497 - Unship all Universal CRT DLLs. r?#build

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1842497 - Unship d3dcompiler_47.dll. r?#build

Depends on D183099

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1842497 - Remove dead code from gfx/gl/GLLibraryEGL.cpp. r?#gfx-reviewers

Depends on D183100

Comment 4

[Phabricator Automation]

Comment on attachment 9342963 [details]
Bug 1842497 - Remove dead code from gfx/gl/GLLibraryEGL.cpp. r?#gfx-reviewers

Revision D183101 was moved to bug 1843681. Setting attachment 9342963 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/154481407ca2
Unship all Universal CRT DLLs. r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/3a71e5ba5001
Unship d3dcompiler_47.dll. r=firefox-build-system-reviewers,glandium

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/154481407ca2
https://hg.mozilla.org/mozilla-central/rev/3a71e5ba5001

Comment 7

[Ryan VanderMeulen [:RyanVM]]

AFAICT, this still leaves the DLLs behind after updating. Do we have any way of removing them as well?

Comment 8

[Mike Hommey [:glandium]]

https://searchfox.org/mozilla-central/source/browser/installer/removed-files.in but that's supposed to be automatic these days.

Comment 9

[Masatoshi Kimura [:emk]]

I confirmed that both update and pave over install removed the unshipped files.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Bug 1842497 - Port bug 1842497: Unship d3dcompiler_47.dll and Universal CRT DLLs. r=#thunderbird-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/44e3278aa865
Port bug 1842497: Unship d3dcompiler_47.dll and Universal CRT DLLs. r=mkmelin

Comment 12

[Masatoshi Kimura [:emk]]

Hm, the 115.0.3 to 116.0 update did not remove unshipped dlls. Partial updates do not remove them?

Comment 13

[Masatoshi Kimura [:emk]]

Ah, 116.0 does not contain this fix yet.