Closed
Bug 184256
Opened 22 years ago
Closed 22 years ago
Canedit group_control_map entry does not prevent making attachments
Categories
(Bugzilla :: Attachments & Requests, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bugreport, Assigned: bugreport)
Details
Attachments
(1 file, 1 obsolete file)
|
2.84 KB,
patch
|
bbaetz
:
review+
|
Details | Diff | Splinter Review |
A user who is not supposed to be able to comment on or change a bug in a
particular product because of the canedit group_control_map entry can still
create (and probably change) attachments.
While they can only add information, but they are not supposed to be able to do so.
|
Assignee | |
Comment 1•22 years ago
|
||
I'll fix today
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 2•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108683 -
Flags: review?(bbaetz)
|
|
||
Comment 3•22 years ago
|
||
Comment on attachment 108683 [details] [diff] [review]
The fix
You need to change Attachment.pm::canedit, too, for the show_bug ui to be
correct.
validateCanChangeAttachment could then be rolled into validateCanEdit, although
tha tmay be a bad idea, since we don't want the group lookup running for each
obsoleted attachment.
Attachment #108683 -
Flags: review?(bbaetz) → review-
|
|
Assignee | |
Comment 4•22 years ago
|
||
This adds supression of the Attachment.pm edit fields. It is a single lookup
for the bug.
Attachment #108683 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108812 -
Flags: review?(bbaetz)
|
|
||
Updated•22 years ago
|
Attachment #108812 -
Flags: review?(bbaetz) → review+
|
|
Assignee | |
Updated•22 years ago
|
Flags: approval?
|
||
Updated•22 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checking in Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Attachment.pm,v <-- Attachment.pm
new revision: 1.13; previous revision: 1.12
done
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v <-- attachment.cgi
new revision: 1.34; previous revision: 1.33
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•