1842608 - Text selection handles are not displayed on Nightly.

Status: RESOLVED FIXED

(Fenix :: General, defect, P1)

Description

[tesmite]

User Agent: Mozilla/5.0 (Android 9; Mobile; rv:109.0) Gecko/117.0 Firefox/117.0

Steps to reproduce:

After update to 117.0a1 (Build #2015961379), Text selection handles are not displayed.
However, although it is not actually visible, it exists and you can move the range by selecting it.

Comment 2

[Andrei Mocirean]

Hello,
I was able to reproduce the issue on the latest Nightly build (117.0a1) from 11th of July 2023. The issue is only reproducible in the Nightly build, Beta and RC are not affected.
Devices used for testing: Google Pixel 7 Pro (Android 13), Lenovo Tab P11 Plus (Android 12).
Thank you!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Hard to get a definitive regression range without having an idea of a last-known-good build, but here's a couple days' worth of Gecko commits leading up to the first affected Nightly build:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4d87ff75575&tochange=76990d265adf8f3e06e2352d422a410ae6c899a0

Is this reproducible with GVE (and bisectable with mozregression)?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Offhand, bug 1817723 looks maybe related?

Comment 5

[Oana Horvath [:ohorvath]]

mozregression doesn't work ATM on GVE, see https://bugzilla.mozilla.org/show_bug.cgi?id=1835067. But we'll try to get the first bad build if possible.

Comment 6

[Zeid Zabaneh [:zeid]]

Please use mozregression 5.4.1.dev1 for the time being until the next version is released. This dev version has a workaround that will allow you to run GVE.

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I cannot reprduce on desktop Nightly with layout.accessiblecaret.enabled=true and layout.accessiblecaret.hide_carets_for_mouse_input=false. I don't have a Android device to reproduce at hand.

In the regression range in comment 3, bug 1824886 contains a refactor to AccessibleCaret's internal display mechanism.

Emilio, could you take a look if your patches cause this? (Change Severity to S1 because AccessibleCaret is missing on mobile device.)

Comment 8

[Sean Feng [:sefeng]]

I am able to use mozregression to reproduce this and that leads to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=87f35bfe2247c1dface09d2c1f0f9c6ec6ab2bfa&tochange=60d4eb46c8b40ab0cd000c9ef298c63c45539be7, which is Emilio's patch.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

I can repro on my device (but not on desktop as Ting-Yu mentioned, which is weird). Checking.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1842608 - Move Android's accessiblecaret SVG's to layout/style/res. r=TYLin

We need these to be contentaccessible. Let's make sure they use the same
set-up as desktop's images.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1842608 - Don't ship accessiblecaret's desktop pngs on mobile. r=TYLin

The less useless files the better.

Depends on D183293

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1b606076e2
Move Android's accessiblecaret SVG's to layout/style/res. r=TYLin,geckoview-reviewers,owlish

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e607211b8c
Don't ship accessiblecaret's desktop pngs on mobile. r=TYLin

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ae1b606076e2
https://hg.mozilla.org/mozilla-central/rev/09e607211b8c