Closed Bug 1842619 Opened 5 months ago Closed 5 months ago

Update BiDi network events to support the network.BytesValue format for headers and cookies

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
3

Tracking

(firefox117 fixed)

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m8], [wptsync upstream] [webdriver:relnote])

Attachments

(2 files)

Bug 1842619 - [bidi] Serialize header and cookies values as network.BytesValue
48 bytes, text/x-phabricator-request
Details | Review
Bug 1842619 - [wdspec] Update BiDi network tests to assert cookie and header values as network.BytesValue
48 bytes, text/x-phabricator-request
Details | Review

PR 472 is changing the way we serialize/deserialize headers and cookies for network events in a way that's backward incompatible.

We should update the implementation (and wdspec tests) to be compatible with the new specification.

I suggest we try to fit this in M8, since it's a compat-affecting change and it affects network request interception.

Whiteboard: [webdriver:triage]
Points: --- → 3
Priority: -- → P1
Whiteboard: [webdriver:triage] → [webdriver:m8]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75457bb2d3a5
[bidi] Serialize header and cookies values as network.BytesValue r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/c1d9936545b5
[wdspec] Update BiDi network tests to assert cookie and header values as network.BytesValue r=webdriver-reviewers,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41109 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/75457bb2d3a5
https://hg.mozilla.org/mozilla-central/rev/c1d9936545b5

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m8], [wptsync upstream] → [webdriver:m8], [wptsync upstream] [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.