1842629 - No longer attempt to repair/re-init the OpenPGP secret storage if the automatic passphrase doesn't work

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement, P2)

Description

[Kai Engert [:KaiE:]]

If the feature to use individual OpenPGP secret key passphrases (bug 1679278) has been enabled, then we should never automatically attempt to re-initialize the secret key storage.

If mail.openpgp.passphrases.enable is set to true, the user might no longer be using that automatic passphrase anyway.

(We had introduced the re-init of the automatic passphrase because of bug 1790610 and the related broken profile import feature.)

Comment 1

[Kai Engert [:KaiE:]]

Actually, I think that TB 115 and later should never re-init (move away) the secring.gpg file,
even if the pref is false.

Because the user might have had the pref enabled previously, set passphrases, then disabled the pref again.
Our code won't show the UI for managing the passphrase, but it would still correctly handle prompting for that passphrase.

Given that 115 doesn't suffer from the original bug (described in bug 1790605), it should be unnecessry to recreate secring.gpg

Comment 2

[Kai Engert [:KaiE:]]

I'll wait until the work on bug 1835786 has completed.
Afterwards I'll request review on this cleanup.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1842629 - In 115 and later, never re-init secring.gpg. r=mkmelin

Depends on D183178

Comment 4

[Kai Engert [:KaiE:]]

Finally bug 1835786 was shipped on all stable branches, we're ready to make this change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/491a82e6e9d8
In 115 and later, never re-init secring.gpg. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7c526ce913d
follow-up - Remove unused import. rs=linting

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9343109 [details]
Bug 1842629 - In 115 and later, never re-init secring.gpg. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/5d1c9ccc656f
https://hg.mozilla.org/releases/comm-beta/rev/dc93c35121c2

Comment 9

[Wayne Mery (:wsmwk)]

Is this still wanted for 115?

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 9343109 [details]
Bug 1842629 - In 115 and later, never re-init secring.gpg. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1790610
User impact if declined: Potential, theoretical dataloss
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low; lower risk for problems with this code removal

Comment 11

[Kai Engert [:KaiE:]]

(In reply to Wayne Mery (:wsmwk) from comment #9)

Is this still wanted for 115?

yes please.

Comment 12

[Kai Engert [:KaiE:]]

Comment on attachment 9343109 [details]
Bug 1842629 - In 115 and later, never re-init secring.gpg. r=mkmelin

Actually, I'm temporarily withdrawing my approval request.

Looking at the patch just raised some uncertainty.

I want to go back and doublecheck one more scencario.

Comment 13

[Wayne Mery (:wsmwk)]

Do you want to reopen this bug?