Closed
Bug 1842662
Opened 1 year ago
Closed 1 year ago
Update snippets / highlights component to receive data from ShoppingContainer
Categories
(Firefox :: Shopping, enhancement)
Firefox
Shopping
Tracking
()
RESOLVED
FIXED
117 Branch
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: amy, Assigned: amy)
References
Details
(Whiteboard: [fidefe-shopping])
Attachments
(1 file)
In bug 1841086 we created a component to pass data from the API to UI components, highlights.mjs needs to add a new property for highlights data.
we can update ReviewHighlights
in highlights.mjs
to accept the highlights data object from the API by updating it's properties:
class ReviewHighlights extends MozLitElement {
static properties = {
highlights: { type: Object }
}
which then allows shopping-container.mjs
to pass the highlights property to it.
So in highlights.mjs
we can do something like,
render() {
return html`
// html stuff here
// function to tidy up data and generate smaller UI bits
${this.createHighlightsTemplate(this.highlights)}
}
then this.highlights
is passed to highlights.mjs
in shopping-container.mjs
via:
render() {
return html`
<review-highlights highlights=${this.highlights}></review-highlights>
`
}
Updated•1 year ago
|
Duplicate of this bug: 1842878
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Attachment #9344306 -
Attachment description: WIP: Bug 1842662 - update highlights component to receive data from ShoppingContainer. r=#shopping-reviewers → Bug 1842662 - update highlights component to receive data from ShoppingContainer. r=#shopping-reviewers
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8835158ccf9
update highlights component to receive data from ShoppingContainer. r=shopping-reviewers,Gijs
Comment 4•1 year ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•