1842696 - New Import Wizard fails to import data from Safari if there are no bookmarks saved

Status: RESOLVED DUPLICATE of bug 1838432

(Firefox :: Migration, defect)

Description

[Punam Dahiya [:pdahiya]]

Attachment: New Import Dialog with Safari browser selected by default

On MacOS Monterey, with new import wizard trying to import data from Safari doesn't complete the import and stays stuck on Open dialog even after Safari folder is selected (See attached)

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot with Select Safari folder and choose open dialog instruction

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot of Open dialog that reopens after Safari folder select

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hi pdahiya,

Interesting... so, to be clear, you chose "Safari" in the Library folder and clicked the "Open" button in the file picker window, and somehow the file picker window stayed open? Are you able to post a screen cast of what you saw?

Comment 4

[Punam Dahiya [:pdahiya]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

Hi pdahiya,

Interesting... so, to be clear, you chose "Safari" in the Library folder and clicked the "Open" button in the file picker window, and somehow the file picker window stayed open? Are you able to post a screen cast of what you saw?

Hi Mike, Here's the screen cast with latest Nightly on MacOS, it could be permission issue on my local machine but not sure.

https://drive.google.com/file/d/13aYFSZLFprtnG-rhW3mm5KdBAbd_RnWJ/view?usp=sharing

Thanks!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hm. Interesting... which version of macOS is this?

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #5)

Hm. Interesting... which version of macOS is this?

It's MacOS Monterey version 12.6

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey atrif, have you seen this sort of thing in your testing on macOS? See comment 4.

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)

Hey atrif, have you seen this sort of thing in your testing on macOS? See comment 4.

Hello Mike! From what I see in the screen recording from comment 4 there's only History saved in Safari Browser so it's most likely bug 1838432. History alone cannot be imported from Safari only if there is a bookmark saved as well. Maybe if a user bookmark is made on Safari browser (and Firefox is restarted if the bookmark it's made while Firefox is opened) then the import should work as expected.

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #8)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)

Hey atrif, have you seen this sort of thing in your testing on macOS? See comment 4.

Hello Mike! From what I see in the screen recording from comment 4 there's only History saved in Safari Browser so it's most likely bug 1838432. History alone cannot be imported from Safari only if there is a bookmark saved as well. Maybe if a user bookmark is made on Safari browser (and Firefox is restarted if the bookmark it's made while Firefox is opened) then the import should work as expected.

just verified, with bookmarks added in Safari, I was able to complete import flow without needing Open dialog step.

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Punam Dahiya [:pdahiya] from comment #9)

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #8)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)

Hey atrif, have you seen this sort of thing in your testing on macOS? See comment 4.

Hello Mike! From what I see in the screen recording from comment 4 there's only History saved in Safari Browser so it's most likely bug 1838432. History alone cannot be imported from Safari only if there is a bookmark saved as well. Maybe if a user bookmark is made on Safari browser (and Firefox is restarted if the bookmark it's made while Firefox is opened) then the import should work as expected.

just verified, with bookmarks added in Safari, I was able to complete import flow without needing Open dialog step.

Yes, I saw that. It seems that Safari folder permissions are granted in a way if they are done before saving a bookmark even if the file picker window is reopened but the import does not work until at least one user bookmark is created in Safari. Thank you for the verification!

Comment 11

[:Gijs (he/him)]

I expect this has to do with the code here that tries to read the bookmarks file to determine if permissions are available. If there is no such file, I guess perhaps this check fails and keeps prompting to select the folder? It would be good to verify this...

Mike, I'll needinfo you here for next week as I'm not sure how to prioritize this in light of other / recent improvements here.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hi pdahiya, I think this should be fixed now that bug 1838432 is closed. Are you able to confirm?

Comment 13

[Punam Dahiya [:pdahiya]]

Just tested and was able to complete import flow with 0 bookmarks, marking issue resolved duplicate of bug 1838432, thanks!