1842711 - [wpt-sync] Sync PR 40960 - Move popover invoker CHECK

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40960 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40960
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Move popover invoker CHECK

I added this CHECK in http://crrev.com/1166594 but it will get hit when
showPopover is called while the popover is open with an invoker. This
patch moves the CHECK down past the IsPopoverReady check to avoid
getting hit. If the popover is already open, then the IsPopoverReady
check will return before the CHECK is run.

The motivation behind the CHECK is still fine - it ensures that while
the popover is closed, it can't have an invoker set.

Fixed: 1463384
Change-Id: Ie75a1026acefd9ce8018caf96b2bb314a18ac730

Reviewed-on: https://chromium-review.googlesource.com/4676654
WPT-Export-Revision: ca8528242738eb95b430157b01f2cc88a4cd84c2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff647e0627f42a44a513d10fe81126e26b8c5eac

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c84ceed4658
[wpt PR 40960] - Move popover invoker CHECK, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9c84ceed4658