1842755 - Colour management not working in Youtube videos with version 115

Status: UNCONFIRMED

(Core :: Graphics: Color Management, defect, P2)

Description

[Archer_Legend]

Attachment: gfx.color.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Actual results:

Youtube videos are no longer colour managed.
With version 114 Youtube videos followed the same colour management like the rest of the browser and used the .icm profile installed on Windows.
After the update the browser is correctly colour managed but Youtube is not anymore resulting in oversaturation in all the videos.
In the attached file there is the gfx.colour_management configuration I have in Firefox. It used to work flawlessly with that settings on version 114 but does not work anymore with the current one, I have tried changing various settings but that did not fix the problem.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: Color Management' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Bob Hood [:bhood]]

Kelsey, please check my Severity setting on this. May be low.

Comment 3

[Archer_Legend]

Version 115.0.2 released and the issue is still present.

Comment 4

[Kelsey Gilbert [:jgilbert]]

S3 P2 sounds right.

Archer: Can you attach your about:support's "Copy raw data to clipboard"?

Comment 5

[Kelsey Gilbert [:jgilbert]]

@sotaro: Did anything ship in 115 but not 114 for videos?

Comment 6

[Archer_Legend]

Attachment: about:support raw data

Comment 7

[Archer_Legend]

(In reply to Kelsey Gilbert [:jgilbert] from comment #5)

@sotaro: Did anything ship in 115 but not 114 for videos?

With 115 Nvidia upscaling for Youtube videos is supported so I guess that something broke with the colour management while implementing that feature. (I am not running an RTX gpu though, I am on an Intel UHD 620 graphics).

Comment 8

[Archer_Legend]

Is there any information regarding this bug, has it been noted for a fix down the line?

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Kelsey Gilbert [:jgilbert] from comment #5)

@sotaro: Did anything ship in 115 but not 114 for videos?

I did not ship anything in 115.

From the following, Bug 1833030 seems only change around DCLayerTree in 115. It might be related to the problem.

• https://hg.mozilla.org/mozilla-central/log/tip/gfx/webrender_bindings/DCLayerTree.cpp

Comment 10

[Ben]

Can confirm this is an issue in 115. Had to revert to 114.

Comment 11

[Archer_Legend]

The issue is still present with version 116.
I would like to receive feedback whether there are plans to fix this issue introduced with 115 or if it won't be fixed in the near future.

Comment 12

[Archer_Legend]

The issue is still present in relase 117.

Comment 13

[Archer_Legend]

The issue is still present in release 118, it is also being followed up in this bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1850669

Comment 14

[Andrew Ke]

I am unable to replicate the behavior described by Archer_Legend. On my system, for both Firefox releases 114 and 120, color management does not work for videos, so videos are always oversaturated. Photos and HTML are correctly color managed. As far as I remember, this behavior has been consistent for the past >3 years.

My system (XPS 7590, Windows 10, DCI-P3 OLED, Firefox running on Intel UHD 630) is quite similar to Archer_Legend's (Firefox running on Intel UHD 620). I have also set gfx.color_management.mode = 1 and gfx.color_management.rendering_intent = 1 just like Archer_Legend.

I have found that mpv and Chromium 121 are able to do video color management, perhaps Firefox developers can look towards there for inspiration.

mpv video color management works with --icc-profile-auto (hardware decode on) and is very efficient (4K30 VP9 playback: 4W CPU power on i7-9750H)

Chromium 121 video color management works with Hardware-accelerated video decode: Disabled and Choose ANGLE graphics backend: D3D11on12. Power consumption is higher at 10-12W CPU power (4K30 VP9). I am not sure how Edge and Chrome versions map to chromium, but video color management used to be broken in Chrome and Edge and was fixed somewhere between release 100 and 115 for edge, and 100 and 120 for Chrome.

Comment 15

[Andrew Ke]

I retested Firefox 114 and video color management is broken only in YouTube (non fullscreen). I tried bilibili and Vimeo, and video color management works in both fullscreen and non fullscreen.

For YouTube, video color management works in fullscreen, but is broken when not in fullscreen. Video color management also works when using picture-in-picture. This behavior is consistent for both h264 and vp9 playback.

Another way to verify that color management is working is Task Manager>GPU>Video Processing. Whenever video color management works, the Video Processing graph will show activity instead of being at 0. This is for Intel HD.

Comment 16

[Andrew Ke]

After more testing of Firefox 114, color management for YouTube

1. does not work in Default view
2. works in Theater mode (full width of window)
3. works in fullscreen
4. works in picture-in-picture

Color management also

5. works in bilibili (fullscreen and minimised)
6. works in Vimeo (fullscreen and minimised)

I also tested Firefox 121 beta and video color management does not work for every case (1-6). Color management still works for HTML and pictures.

Comment 17

[Ben]

This issue is still persistent in 127.0.2. I could get around this issue by playing Youtube videos in Cinema mode in an older version. I believe that was version 113.

Comment 18

[Ben]

(In reply to Ben from comment #17)

This issue is still persistent in 127.0.2. I could get around this issue by playing Youtube videos in Cinema mode in an older version. I believe that was version 113.

Might have been 114 if my comment above is correct.