1842886 - Report Site Issue missing/broken on GV 117.0.20230710155516

Status: VERIFIED FIXED

(Fenix :: General, defect)

Description

[Aaron Train [:aaronmt]]

Extension seems to be available in assets/extensions/webcompat-reporter (base.apk), however any site I visit on (2134666ca60200c5f2003c3cf46bf018571737aa) 2134666c Update GeckoView (Nightly) to 117.0.20230710155516 I don't see the 'Report Site Issue' menu item at all.

Tested on a Pixel 6 (Android 13), built clean

Comment 1

[Aaron Train [:aaronmt]]

It appears that it shows up in menu on second launch of the application, however on tap I see

[JavaScript Error: "[Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: jar:file:///data/app/~~-jYFM05PaUlJJ9DMdv05YQ==/org.mozilla.fenix.debug-PLl9oEubrk57OXgZenA57g==/base.apk!/assets/extensions/webcompat-reporter/experimentalAPIs/tabExtras.js :: <TOP_LEVEL> :: line 9"  data: no]"]
@jar:file:///data/app/~~-jYFM05PaUlJJ9DMdv05YQ==/org.mozilla.fenix.debug-PLl9oEubrk57OXgZenA57g==/base.apk!/assets/extensions/webcompat-reporter/experimentalAPIs/tabExtras.js:9:32
asyncLoadModule/module.asyncLoaded<@resource://gre/modules/ExtensionCommon.sys.mjs:1734:14

2023-07-11 14:23:58.744 31630-31656 GeckoConsole            org.mozilla.fenix.debug              E  [JavaScript Error: "WebCompat Reporter: unexpected error Error: An unexpected error occurred"]

Comment 2

[Aaron Train [:aaronmt]]

Hi Tooru, I believe bug 1780695 is the regressor here as I took a look at the webcompat-reporter not working in Fenix, and in browserInfo.js and in tabExtra.js I see the Services.jsm import. I don't know who are the authors of the webcompat-reporter feature but I assume the extension needs updating now.

Comment 3

[Mark Banner (:standard8)]

It looks like these references need updating in android-components: https://searchfox.org/mozilla-mobile/search?q=Services.jsm&path=&case=false&regexp=false

Services should now be available in the global scope, so removing those lines should work.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:arai, since you are the author of the regressor, bug 1780695, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Thomas Wisniewski [:twisniewski]]

I think we just need to backport a couple of changes that landed for ESMification on moz-central for the reporter, but which never made it into the mobile repo. I'm working on a patch now.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842886 - update the webcompat-reporter feature to un-break it (#2801)

Comment 7

[BMO Github Automation]

Authored by https://github.com/wisniewskit
https://github.com/mozilla-mobile/firefox-android/commit/f0cb134bda8c399519707b150acc1614c093f804
[main] Bug 1842886 - update the webcompat-reporter feature to un-break it after ESMification changes

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842886 - bump the version of the webcompat-reporter addon up (#2819)

Comment 9

[BMO Github Automation]

Authored by https://github.com/wisniewskit
https://github.com/mozilla-mobile/firefox-android/commit/ae503d496bb5d85689aafd0cb5821c288ab73d5a
[main] Bug 1842886 - bump the version number of the webcompat-reporter feature addon to a higher number

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed on the latest version from main.