1842913 - Update parent window code to check optedIn pref

Status: RESOLVED FIXED

(Firefox :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The current ShoppingSidebarManager assumes the sidebar should be shown if the browser.shopping.experience2023.enabled pref is true. However, there's another pref that should also be used to determine the state of the UI, browser.shopping.experience2023.optedIn:

If browser.shopping.experience2023.enabled is true and browser.shopping.experience2023.optedIn is true, then we show the sidebar content on product pages. (This is already implemented, only using .enabled and not checking .optedIn).

If browser.shopping.experience2023.enabled is true and browser.shopping.experience2023.optedIn is false, then we will show the page action button, but not automatically open the sidebar, on product pages. (Hence, we'll still need to connect the onLocationChange listener.) In this case, when the sidebar is opened, whether by the user or by the messaging system code, we will render the sidebar's header, but not send the product info to the backend, and the messaging system code will display the onboarding card.

If browser.shopping.experience2023.enabled is false, then we don't want the page action button or sidebar to be shown in the UI. (This is already implemented.)

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: WIP: Bug 1842913 - Update parent window code to check optedIn pref. r?#shopping-reviewers

Also fixes bug 1844106, "Update shopping container to display onboarding
based on optedIn pref".

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1842913 - Update parent window code to check optedIn pref r?#shopping-reviewers

Also fixes bug 1844106, "Update shopping container to display onboarding
based on optedIn pref".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2a7f1a6f481
Update parent window code to check optedIn pref r=shopping-reviewers,Gijs

Comment 4

[Serban Stanca [:SerbanS]]

Backed out as requested by dev for eventually failing the linter.

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3826a2c876b4
Update parent window code to check optedIn pref r=shopping-reviewers,Gijs

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3826a2c876b4