1843002 - Add nonce and parser-metadata to ScriptFetchOptions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Tom Schuster (MoCo) | OOO back 1. Dec]

In the specification Script fetch options contains the cryptographic nonce and the parser metadata. Our implementation of ScriptFetchOptions however doesn't and instead queries the context element. When preloading we don't have an element so we need to provide this information explicitly.

Comment 1

[Tom Schuster (MoCo) | OOO back 1. Dec]

Attachment: Bug 1843002 - Add nonce to ScriptFetchOptions. r?allstarschh

Comment 2

[Tom Schuster (MoCo) | OOO back 1. Dec]

Attachment: Bug 1843002 - Add parser-metadata to ScriptFetchOptions. r?allstarschh

Depends on D183365

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d381b6365111
Add nonce to ScriptFetchOptions. r=allstarschh,smaug
https://hg.mozilla.org/integration/autoland/rev/21a9bee8f772
Add parser-metadata to ScriptFetchOptions. r=allstarschh,smaug

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages in ScriptLoadRequest.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/js/loader/ScriptLoadRequest.h:302:3: error: declaration of 'JS::loader::ParserMetadata JS::loader::ScriptLoadRequest::ParserMetadata() const' [-fpermissive]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff52f02b1f93
Add nonce to ScriptFetchOptions. r=allstarschh,smaug
https://hg.mozilla.org/integration/autoland/rev/7fdd6b03d37d
Add parser-metadata to ScriptFetchOptions. r=allstarschh,smaug

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ff52f02b1f93
https://hg.mozilla.org/mozilla-central/rev/7fdd6b03d37d