1843074 - SkippableTimer.done should be set immediately

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Marco Bonardo [:mak]]

There's a potential pitfall in setting .done after promises resolves, where the callback may be invoked more than once.
Not the end of the worls siince once the promise is resolved further actions are ignored.. but still pointless work.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1843074 - SkippableTimer.done should be set immediately. r=scunnane

Invoking fire() in a loop may invoke the callback multiple times because done
is not set immediately.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e9a021ee302
SkippableTimer.done should be set immediately. r=scunnane

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1e9a021ee302