1843181 - EqualRange should return a std::pair, not a CompactPair

Status: RESOLVED FIXED

(Core :: MFBT, task, P5)

Description

[Markus Stange [:mstange]]

EqualRange currently returns a CompactPair:

https://searchfox.org/mozilla-central/rev/0b021daa5955f0288ef6477fc51be33f7f452f9a/mfbt/BinarySearch.h#218-221

template <typename Container, typename Comparator>
CompactPair<size_t, size_t> EqualRange(const Container& aContainer,
                                       size_t aBegin, size_t aEnd,
                                       const Comparator& aCompare) {

I don't think the reasons for preferring CompactPair over std::pair apply here. Using std::pair would be more ergonomic because you can do this:

auto [rangeStart, rangeEnd] = mozilla::EqualRange(...);

I didn't end up needing this change for anything, but I think it makes sense to do anyway.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1843181 - Make EqualRange return a std::pair. r=sergesanspaille

mozilla::CompactPair doesn't seem appropriate because its base class optimization doesn't apply.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801cb21ffbb0
Make EqualRange return a std::pair. r=sergesanspaille

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/801cb21ffbb0