Closed Bug 1843302 Opened 2 years ago Closed 2 years ago

The Mouse cursor should change its state according to the edge we resize it from for added images and drawings in PDF documents

Categories

(Firefox :: PDF Viewer, enhancement)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
117 Branch
Tracking Status
firefox-esr102 --- disabled
firefox-esr115 --- disabled
firefox115 --- disabled
firefox116 --- disabled
firefox117 --- verified

People

(Reporter: rdoghi, Assigned: calixte)

References

Details

Attachments

(1 file)

Found in

  • Nightly 117.0a1 (2023-07-12)

Affected versions

  • Nightly 117.0a1 (2023-07-12)

Tested platforms

  • Affected platforms: ALL

Steps to reproduce

  1. Open a PDF file in Firefox.
  2. Click the Add an image button from the PDF toolbar.
  3. Grab one of the edges of the image in order to resize it.

Expected result

  • The Mouse cursor should change its state when grabbing from the bottom side, right side or the botom right corner.

Actual result

  • The Mouse cursor does not change its state when grabbing from a different edge.

Regression range

  • N/A

AFAIK, when an HTML element is made resizable, the resizer is only available in the bottom right corner.
In reading the specs:
https://drafts.csswg.org/css-ui/#resizing
I don't think it's possible to have such a feature without implementing it ourselves.

Hi @Calixte, since the image can only be resized from the bottom right corner I think the mouse cursor should change to Diagonal arrows instead of the Left/Right arrows because the image will resize in both Width and Height not just the Width.
If its ok the way it is, we can close this issue as a wont fix since we can no longer grab the right or bottom edges of an image in order to resize it.

Flags: needinfo?(cdenizet)

This also affects drawings.

Blocks: pdf-js-edit
No longer blocks: 1843246
Summary: The Mouse cursor should change its state according to the edge we resize it from for an Added image to a PDF document → The Mouse cursor should change its state according to the edge we resize it from for added images and drawings in PDF documents
Flags: needinfo?(cdenizet)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

This issue is verified as fixed in our latest Nightly build 117.0a1 (2023-07-26), it looks great !

Status: RESOLVED → VERIFIED
Assignee: nobody → cdenizet
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: