1843320 - Semantically indicate current paused line when stepping

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

When stepping, current line is not indicated semantically (aria-current?). Should probably also get focus or similar so that a screen reader user knows where the point of interest is.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:bomsy, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

Let's only do this for CodeMirror 6, as cm5 might require a very different solution

Comment 3

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

Attachment: Debugger paused section

Anna, I was wondering if it would be enough if we add a reference to the file, line and column (and maybe function name) in the yellow section we have in the Debugger, and add a aria-live: polite attribute on it. If I understand what the attribute does, this would be read out when the panel changes.
Maybe I can try to add a quick patch so we can check if this is enough for fixing this issue?

Comment 4

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

Attachment: Bug 1843320 - [devtools] Turn WhyPaused into a live region and add paused location information r=#devtools-reviewers

Comment 5

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

Attachment: WhyPaused with location information

I pushed a WIP patch at https://phabricator.services.mozilla.com/D223928
Testing with voice over, the content of the element is read when stepping (although we might make it assertive instead of polite) which seems to cover the original issue?
Here the patch is very naive, and in VoiceOver, it seems that the "Paused while stepping" part is not repeated when stepping, I guess because there's some kind of mechanism to only read what changed inside the element, and the location information I added are in separate element (to avoid dealing with the localization for now).

How does that sound Anna?

Comment 6

[Anna Yeddi [:ayeddi]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #5)

Created attachment 9427699 [details]
WhyPaused with location information

I pushed a WIP patch at https://phabricator.services.mozilla.com/D223928
Testing with voice over, the content of the element is read when stepping (although we might make it assertive instead of polite) which seems to cover the original issue?
Here the patch is very naive, and in VoiceOver, it seems that the "Paused while stepping" part is not repeated when stepping, I guess because there's some kind of mechanism to only read what changed inside the element, and the location information I added are in separate element (to avoid dealing with the localization for now).

How does that sound Anna?

Hi Nicolas, thank you for the patch!

While we could add aria-atomic to the live region and ask the assistive technology to announce the full string, I think it is actually for the best that only the newly updated content is being announced: I think, after the first (full) announcement, in the debugger mode it would be expected to keep "pause while stepping". We want to reduce the verbosity of the announcement and the current implementation should be providing us with exactly that.

In general, I like the approach with adding the reference to the location information to the panel. It would definitely make my own debugging easier

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c72b46ec8e4
[devtools] Turn WhyPaused into a live region and add paused location information r=nchevobbe,devtools-reviewers,accessibility-frontend-reviewers,nlapre

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3c72b46ec8e4