1843339 - [wpt-sync] Sync PR 41020 - Add option to send automatic beacons only once.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41020 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41020
Details from upstream follow.

Liam Brady <[e-mail]> wrote:

Add option to send automatic beacons only once.

Automatic beacons currently have a design flaw that can cause extra
unwanted beacons to be sent out. For example, a top-level navigation
beacon is set in a click handler for an ad when the user clicks on the
ad. The ad's screen then changes to have a button that says "why this
ad?" which takes the user to an explainer page. However, the automatic
beacon data is still in place, so if a user goes back and clicks on "why
this ad?" to perform a different top-level navigation, the beacon will
send out again as if the user clicked on the ad normally. This creates
an erroneous impression and results in incorrect data being sent to
reporting servers.

To fix the issue, this CL introduces a new parameter to the FenceEvent
dictionary: onlyForNextAutomaticBeacon. It defauls to false (to
preserve the current default behavior of automatic beacons). If set to
true, when an automatic beacon is sent out, the automatic beacon data
will be cleared.

This CL also moves AutomaticBeaconInfo implementation functions from
"fenced_frame_reporter.cc" to "fenced_frame_config.cc" to reflect the
fact that its definition lives in "fenced_frame_config.h".

Change-Id: I1240557844a3c47c680a0f3d8a227e31794ab49f
Bug: 1464599

Reviewed-on: https://chromium-review.googlesource.com/4671534
WPT-Export-Revision: 986057966f44bf3a970c04c45c7cd921eca53c10

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4104eea5689f43b878c9af45d062d6ecaf702d80

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fenced-frame/automatic-beacon-two-events-clear.https.html [wpt.fyi]
  • Set expiring automatic beacon but trigger two events in a click handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-two-events-persist.https.html [wpt.fyi]
  • Set persisting automatic beacon but trigger two events in a click handler: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab819666205a
[wpt PR 41020] - Add option to send automatic beacons only once., a=testonly
https://hg.mozilla.org/integration/autoland/rev/0448903c5127
[wpt PR 41020] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ab819666205a
https://hg.mozilla.org/mozilla-central/rev/0448903c5127