1843343 - Color contrast is not sufficient for color coded property name and value when property is "filter highlighted"

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Color contrast is insufficient for color-coded CSS properties and their values and variables when they are highlighted after applying a filter on Light theme:
the color contrast ratio is 4:1 for the fucsia regular text against ligh yellow highligh background, 4.2:1 for blue, 4.3:1 for gray (i.e. for “@media” selector text) while they are all expected to be 4.5:1 and higher.

Note that changes in 1843335 might impact this

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-07-13 at 17.05.34.png

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1843343 - [devtools] Fix rule view text contrast for dimmed elements. r=#devtools-reviewers.

This includes:

• selector separator
• ancestor data
• unmatched selector
• unmatched variables
• overridden properties

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1843343 - [devtools] Fix color contrast for highlighted element in rule view. r=#devtools-reviewers.

Depends on D192551

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3672baeaf883
[devtools] Fix rule view text contrast for dimmed elements. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/3c4d4980e9c2
[devtools] Fix color contrast for highlighted element in rule view. r=devtools-reviewers,ochameau.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3672baeaf883
https://hg.mozilla.org/mozilla-central/rev/3c4d4980e9c2