1843386 - Rich suggestion dissapears when complete

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Dale Harvey (:daleharvey)]

If you are typing in a name, "obama" for example, you will see a photo of obama up until you type the last letter "a", at that point while the API still returns a rich suggestion for obama, it gets deduplicated with the heuristic result as they have the same URL (https://www.google.com/search?client=firefox-b-d&q=omaba)

This is a tricky situation, we expect the hueristic result to come first and have a stricter timeout for it, the suggestions can often timeout and are always the slowest results to return but it is also quite confusing to have the result dissapear

Comment 1

[Marco Bonardo [:mak]]

For now we should just avoid deduping rich with non rich. That's what all the other browsers are doing anyway so users should not find it strange.
In the future if the rich suggestion appears just after the heuristic, it would make sense to dedupe but "upgrade" the heuristic with the additional rich information (pretty much merge the 2 results).

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1843386 - Dont deduplicate rich suggestions. r=mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e92949e4c114
Dont deduplicate rich suggestions. r=mak

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e92949e4c114

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using Fx 117.0a1.
The issue is verified fixed using the latest Fx121.0a1 on Windows 10 and Ubuntu 20.04. Rich Suggestion no longer gets updated when typing the last letter of the word.