Add check for qt-mt to configure.in

RESOLVED FIXED

Status

SeaMonkey
Build Config
--
enhancement
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Tim, Assigned: hacker formerly known as seawood@netscape.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

16 years ago
Here is a patch (by timeless) to add a check for qt-mt to configure.in.
(Reporter)

Comment 1

16 years ago
Created attachment 108702 [details] [diff] [review]
patch v1

Almost forgot to attach this...
Again, this is timeless's.

Updated

16 years ago
Attachment #108702 - Flags: review?(seawood)
What is qt-mt and why do we need to check for it?

Comment 3

16 years ago
http://lists.trolltech.com/qt-interest/2000-11/thread00136-0.html
a multithread safe Qt library. On some systems libqt.so isn't present at all (eg
the one i'm using).
Blocks: 79120
Comment on attachment 108702 [details] [diff] [review]
patch v1

Afaict, we don't use any of the qt threading code so we shouldn't require qt-mt
at all.  I'm leaning heavily towards ignoring this completely as I'm not seeing
the advantage to having browsers that could link to qt.so or qt-mt.so and then
having the end-user trying to determine which library they need and why.  At
the very least, that patch should have checked for qt first then fall back to
qt-mt .
Attachment #108702 - Flags: review?(seawood) → review-
We have no reason to check for qt-mt.  Marking wontfix.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → WONTFIX

Comment 6

16 years ago
Umm, you just made Qt/Mozilla impossible to build on many systems.
Qt can be configured with or without threading support; when it's configured
with threading (the default, I believe), the installed library is named
qt-mt, and there is often no -lqt at all.

In the wild evidence of this :

http://marc.theaimsgroup.com/?l=lyx-devel&m=102890071012837&w=2

furthermore, on some systems (noticably freebsd), you need  to look for
-lqt2 (dumb huh ?) and possible -lqt3 as well.

Here is the m4 I use in two projects :

http://movementarian.org/qt.m4
Oh, the drama.  Qt/Mozilla is a hair's breadth from being non-existant so I'm
not really concerned about this at all.  Let's get the port working with the
current requirements before checking for these other variants.

Wild counterexample:
http://ftp.wss.yale.edu/rpm2html/rh73/RedHat/RPMS/qt-3.0.3-11.i386.html



Comment 8

16 years ago
If I can't inject a little melodrama, where's the fun ?

Of course, a /counter-example/ is almost entirely irrelevant.

Comment 9

16 years ago
Fun. My box only has libqt-mt and no libqt ... any idea what I should do in this
case ?
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Comment 10

16 years ago
Created attachment 109918 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt")
Attachment #108702 - Attachment is obsolete: true

Comment 11

16 years ago
Created attachment 109919 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

Alternate patch - first look for the standard library name ("libqt"), then for
the alternate, multithreaded version ("libqt-mt")
[correct version, first patch was the wrong file... ;-( ]
Attachment #109918 - Attachment is obsolete: true
Comment on attachment 109919 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

r=biesi, but you still need moa from cls
Comment on attachment 109919 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

r=cls
Attachment #109919 - Flags: review+
patch checked in
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.