184340 - Add check for qt-mt to configure.in

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Tim]

Here is a patch (by timeless) to add a check for qt-mt to configure.in.

Comment 1

[Tim]

Attachment: patch v1

Almost forgot to attach this...
Again, this is timeless's.

Comment 2

[hacker formerly known as [e-mail]]

What is qt-mt and why do we need to check for it?

Comment 3

[timeless]

http://lists.trolltech.com/qt-interest/2000-11/thread00136-0.html
a multithread safe Qt library. On some systems libqt.so isn't present at all (eg
the one i'm using).

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 108702 [details] [diff] [review]
patch v1

Afaict, we don't use any of the qt threading code so we shouldn't require qt-mt
at all.  I'm leaning heavily towards ignoring this completely as I'm not seeing
the advantage to having browsers that could link to qt.so or qt-mt.so and then
having the end-user trying to determine which library they need and why.  At
the very least, that patch should have checked for qt first then fall back to
qt-mt .

Comment 5

[hacker formerly known as [e-mail]]

We have no reason to check for qt-mt.  Marking wontfix.

Comment 6

[John Levon]

Umm, you just made Qt/Mozilla impossible to build on many systems.
Qt can be configured with or without threading support; when it's configured
with threading (the default, I believe), the installed library is named
qt-mt, and there is often no -lqt at all.

In the wild evidence of this :

http://marc.theaimsgroup.com/?l=lyx-devel&m=102890071012837&w=2

furthermore, on some systems (noticably freebsd), you need  to look for
-lqt2 (dumb huh ?) and possible -lqt3 as well.

Here is the m4 I use in two projects :

http://movementarian.org/qt.m4

Comment 7

[hacker formerly known as [e-mail]]

Oh, the drama.  Qt/Mozilla is a hair's breadth from being non-existant so I'm
not really concerned about this at all.  Let's get the port working with the
current requirements before checking for these other variants.

Wild counterexample:
http://ftp.wss.yale.edu/rpm2html/rh73/RedHat/RPMS/qt-3.0.3-11.i386.html

Comment 8

[John Levon]

If I can't inject a little melodrama, where's the fun ?

Of course, a /counter-example/ is almost entirely irrelevant.

Comment 9

[Roland Mainz]

Fun. My box only has libqt-mt and no libqt ... any idea what I should do in this
case ?

Comment 10

[Roland Mainz]

Attachment: Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt")

Comment 11

[Roland Mainz]

Attachment: Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

Alternate patch - first look for the standard library name ("libqt"), then for
the alternate, multithreaded version ("libqt-mt")
[correct version, first patch was the wrong file... ;-( ]

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 109919 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

r=biesi, but you still need moa from cls

Comment 13

[hacker formerly known as [e-mail]]

Comment on attachment 109919 [details] [diff] [review]
Alternate patch - first look for the standard library name ("libqt"), then for the alternate, multithreaded version ("libqt-mt") [correct version]

r=cls

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

patch checked in