Closed Bug 1843413 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41024 - Revert "[task-attribution] Move to an implicit GCed task container model"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox117 fixed)

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41024 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41024
Details from upstream follow.

Noah Rose Ledesma <noahrose@google.com> wrote:

Revert "[task-attribution] Move to an implicit GCed task container model"

This reverts commit d467c640da15223b2a1da5f50ef895a59358fe76.

Reason for revert: Consistent blink_web_test failures on WebKit Linux ASAN: crbug.com/1464657

Original change's description:

[task-attribution] Move to an implicit GCed task container model

The current task_container_ is a circular buffer with limited space.
That limits the potential use cases for TaskAttribution, and adds
needless complexity. This CL significantly simplifies that model, by
moving the container to be implicit, and relying on GC to clean up tasks
once they are no longer needed - that is, once all their descendent
tasks were done and evicted.

Change-Id: I5d081a3d4208f3b942b9b7f77b539e56cf787c11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614509
Commit-Queue: Yoav Weiss \<yoavweiss@chromium.org>
Reviewed-by: Scott Haseley \<shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1169908}

Change-Id: Ia38c3938e8f89d768c1e1a0f07142403250ed36b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684626
Auto-Submit: Noah Rose Ledesma \<noahrose@google.com>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Noah Rose Ledesma \<noahrose@google.com>
Reviewed-by: Scott Haseley \<shaseley@chromium.org>
Commit-Queue: Scott Haseley \<shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1170036}

PR 41024 applied with additional changes from upstream: dc8e8b70a5888c8561a1c55699645faeb259586b, 2357ee0af29b4e9cd50dfee08fa39f3dddfb46a5, d2f93e3ca8a4b6e07b7e227a88c02b2cff4ab0d6, 2cce010f0960a29db9835403d3925c6bb6279f49

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 28 tests and 1 subtests

Status Summary

Firefox

OK : 7
PASS : 1
FAIL : 6
TIMEOUT: 34
ERROR : 4

Chrome

OK : 28
PASS : 28

Safari

OK : 6
PASS : 1
FAIL : 5
TIMEOUT: 36
ERROR : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f714ac1a6853 [wpt PR 41024] - Revert "[task-attribution] Move to an implicit GCed task container model", a=testonly

https://hg.mozilla.org/mozilla-central/rev/f714ac1a6853

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.