1843587 - Firefox View in a non-private window should never show tabs from a private window

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[B.J. Herbison]

Steps to reproduce:

1. Create a new profile with Firefox View enabled and open several tabs and close some of them.
2. Create a private window.
3. Arrange the windows so Firefox View is visible in the non-private window and the private window has focus.
4. Create a new tab in the private window and close it.
5. Look at Firefox View.

Expected:
5) The recently closed tabs list should show the same view as after step 1.

Actual:
5) The closed tabs from the non-private window aren't displayed, and the closed tab from the private window is shown.

In other words, the private URL and private tab tile from the private window has leaked into non-private Firefox window.

If you start using tabs in the non-private window Firefox View will revert to showing tabs from that window. If you then go to the private window and create and close more tabs the closed tab list from the private window return to Firefox View.

Comment 1

[Sarah Clements [:sclements]]

I'm seeing this as well, but only in Firefox View, not any of the other history > recently closed tabs menus. It looks like we're not passing a window object in getClosedTabsData here. Changing that in recently-closed-tabs to use getClosedTabsData(getWindow()) solves the issue but it seems like not getting closed tabs from private windows should be the default if no window object is passed in. I think this is an easy fix based on the work sfoster did in 1819675.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819675

Comment 3

[Sarah Clements [:sclements]]

Attachment: Bug 1843587 - Change getClosedTabData param to default to non-private window object r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b33cdd7e9bca
Change getClosedTabData param to default to non-private window object r=sfoster,fxview-reviewers,sessionstore-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox117 (nightly). However, the bug still has low severity.

:pluk, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b33cdd7e9bca