1843658 - ASRouter devtools "modify" method fails if message doesn't have groups property

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Shane Hughes [:aminomancer]]

When testing feature callouts from the devtools, I noticed that it throws if the message you input lacks a groups property. You have to add "groups": [] to get it to show. We should figure out why that is and get rid of the requirement, since messages don't actually need to have a groups property. Taking the existing feature callout messages and plugging them into the devtools fails because of this. So we should definitely make sure that all existing messages in tree that work correctly in production will also work from the devtools.

Comment 1

[Punam Dahiya [:pdahiya]]

will be good to check if this issue is specific to feature callout messages showing in devtool

Comment 2

[Emily McMinn :emcminn]

Some basic investigation seems to point to this being specific to Feature Callouts - other messages will throw the console error when the groups property is missing, but still display.

There is a simple fix for the console error, but I'm not sure if that will have an effect on the feature callout messages, since in current Nightly they don't render either way.

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1843658 - Use optional chaining to keep addImpression from throwing an error

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8a2d934ea2
Use optional chaining to keep addImpression from throwing an error r=aminomancer,omc-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1b8a2d934ea2