Closed Bug 1843695 Opened 2 years ago Closed 2 years ago

Perma css/css-values/signs-abs-computed.html | abs(1) should be used-value-equivalent to 1 - assert_not_equals: abs(1) isn't valid in 'z-index'; when Gecko 117 merges to Beta on 2023-07-31

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox115 --- unaffected
firefox116 --- fixed
firefox117 + verified

People

(Reporter: chorotan, Assigned: tlouw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1843695 - Enable abs() and sign() tests on all platforms r=emilio,#layout-reviewers
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review

[Tracking Requested - why for this release]:

[task 2023-07-15T11:13:59.873Z] 11:13:59     INFO - TEST-START | /css/css-values/signs-abs-computed.html
[task 2023-07-15T11:13:59.873Z] 11:13:59     INFO - Closing window e935b234-2c03-404e-b8f9-555660d24489
[task 2023-07-15T11:13:59.957Z] 11:13:59     INFO - PID 8420 | [Child 8755, Main Thread] WARNING: IPC message 'PSessionStore::Msg_SessionStoreUpdate' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:508
[task 2023-07-15T11:14:00.450Z] 11:14:00     INFO - PID 8420 | [Child 8755, Main Thread] WARNING: IPC message 'PSessionStore::Msg_SessionStoreUpdate' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:508
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - 
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - TEST-UNEXPECTED-FAIL | /css/css-values/signs-abs-computed.html | abs(1) should be used-value-equivalent to 1 - assert_not_equals: abs(1) isn't valid in 'z-index'; got the default value instead. got disallowed value "auto"
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - _test_math/<@http://web-platform.test:8000/css/support/numeric-testcommon.js:183:26
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - _test_math@http://web-platform.test:8000/css/support/numeric-testcommon.js:178:9
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - test_math_used@http://web-platform.test:8000/css/support/numeric-testcommon.js:60:15
[task 2023-07-15T11:14:00.813Z] 11:14:00     INFO - @http://web-platform.test:8000/css/css-values/signs-abs-computed.html:24:15
[task 2023-07-15T11:14:00.814Z] 11:14:00     INFO - 
[task 2023-07-15T11:14:00.814Z] 11:14:00     INFO - TEST-PASS | /css/css-values/signs-abs-computed.html | sign(1) should be used-value-equivalent to 1 
[task 2023-07-15T11:14:00.814Z] 11:14:00     INFO - TEST-UNEXPECTED-FAIL | /css/css-values/signs-abs-computed.html | abs(-1) should be used-value-equivalent to 1 - assert_not_equals: abs(-1) isn't valid in 'z-index'; got the default value instead. got disallowed value "auto"
[task 2023-07-15T11:14:00.814Z] 11:14:00     INFO - _test_math/<@http://web-platform.test:8000/css/support/numeric-testcommon.js:183:26
[task 2023-07-15T11:14:00.815Z] 11:14:00     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-15T11:14:00.815Z] 11:14:00     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-15T11:14:00.815Z] 11:14:00     INFO - _test_math@http://web-platform.test:8000/css/support/numeric-testcommon.js:178:9
[task 2023-07-15T11:14:00.815Z] 11:14:00     INFO - test_math_used@http://web-platform.test:8000/css/support/numeric-testcommon.js:60:15
[task 2023-07-15T11:14:00.815Z] 11:14:00     INFO - @http://web-platform.test:8000/css/css-values/signs-abs-computed.html:26:15
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - 
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - TEST-PASS | /css/css-values/signs-abs-computed.html | sign(-1) should be used-value-equivalent to -1 
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - TEST-UNEXPECTED-FAIL | /css/css-values/signs-abs-computed.html | abs(sign(1)) should be used-value-equivalent to 1 - assert_not_equals: abs(sign(1)) isn't valid in 'z-index'; got the default value instead. got disallowed value "auto"
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - _test_math/<@http://web-platform.test:8000/css/support/numeric-testcommon.js:183:26
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - _test_math@http://web-platform.test:8000/css/support/numeric-testcommon.js:178:9
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - test_math_used@http://web-platform.test:8000/css/support/numeric-testcommon.js:60:15
[task 2023-07-15T11:14:00.816Z] 11:14:00     INFO - @http://web-platform.test:8000/css/css-values/signs-abs-computed.html:30:15
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - 
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - TEST-UNEXPECTED-FAIL | /css/css-values/signs-abs-computed.html | abs(sign(sign(1))) should be used-value-equivalent to 1 - assert_not_equals: abs(sign(sign(1))) isn't valid in 'z-index'; got the default value instead. got disallowed value "auto"
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - _test_math/<@http://web-platform.test:8000/css/support/numeric-testcommon.js:183:26
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - _test_math@http://web-platform.test:8000/css/support/numeric-testcommon.js:178:9
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - test_math_used@http://web-platform.test:8000/css/support/numeric-testcommon.js:60:15
[task 2023-07-15T11:14:00.817Z] 11:14:00     INFO - @http://web-platform.test:8000/css/css-values/signs-abs-computed.html:31:15
[task 2023-07-15T11:14:00.818Z] 11:14:00     INFO - 
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - TEST-PASS | /css/css-values/signs-abs-computed.html | sign(sign(sign(1) + sign(1))) should be used-value-equivalent to 1 
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - TEST-UNEXPECTED-FAIL | /css/css-values/signs-abs-computed.html | calc(abs(0.1 + 0.2) + 0.05) should be used-value-equivalent to 0.35 - assert_not_equals: calc(abs(0.1 + 0.2) + 0.05) isn't valid in 'transform'; got the default value instead. got disallowed value "none"
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - _test_math/<@http://web-platform.test:8000/css/support/numeric-testcommon.js:183:26
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2599:25
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - _test_math@http://web-platform.test:8000/css/support/numeric-testcommon.js:178:9
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - test_math_used@http://web-platform.test:8000/css/support/numeric-testcommon.js:60:15
[task 2023-07-15T11:14:00.819Z] 11:14:00     INFO - @http://web-platform.test:8000/css/css-values/signs-abs-computed.html:35:15
[task 2023-07-15T11:14:00.820Z] 11:14:00     INFO -
Flags: needinfo?(tlouw)

This abs() function preference is uplifted to 116 beta, so we need to
enable it on the tests.

Assignee: nobody → tlouw
Status: NEW → ASSIGNED

Comment on attachment 9344005 [details]
Bug 1843695 - Enable abs() and sign() tests on all platforms r=emilio,#layout-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: None, this only allows tests on beta to pass.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects tests and reported failures.
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(tlouw)
Attachment #9344005 - Flags: approval-mozilla-beta?

Comment on attachment 9344005 [details]
Bug 1843695 - Enable abs() and sign() tests on all platforms r=emilio,#layout-reviewers

Fx117 is still in nightly so i don't think beta uplift is necessary as this does not affect 116. Please feel free to add back if I misunderstood.

Attachment #9344005 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Pushed by tlouw@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe9a3469e321 Enable abs() and sign() tests on all platforms r=emilio

Comment on attachment 9344005 [details]
Bug 1843695 - Enable abs() and sign() tests on all platforms r=emilio,#layout-reviewers

Approved for 116.0b7

this was causing failures in beta after uplifting bug 1843527. Uplifted to fix them.

Attachment #9344005 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
See Also: → 1843527

https://hg.mozilla.org/mozilla-central/rev/fe9a3469e321

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Fix verified in today's central as early beta simulation.

Status: RESOLVED → VERIFIED
status-firefox117: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: