Closed Bug 1843720 Opened 2 years ago Closed 2 years ago

Typo in pref name: extension.webextensions.remote in `RemoteWorkerManager.cpp`

Categories

(WebExtensions :: Untriaged, task, P5)

Firefox 115
task

Tracking

(firefox123 fixed)

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: byjxjr3usp, Assigned: eliotj12, NeedInfo)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Actual results:

Likely typo in the comment in dom/workers/remoteworkers/RemoteWorkerManager.cpp:

// when "extension.webextensions.remote" pref is false.

Must be referring to extensions.webextensions.remote.

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Product: Firefox → WebExtensions
Severity: -- → N/A
Type: enhancement → task
Priority: -- → P5
Summary: Typo in pref name: extension.webextensions.remote → Typo in pref name: extension.webextensions.remote in `RemoteWorkerManager.cpp`

William you can assign me thanks

Flags: needinfo?(scott.soosay)

I'd like to be assigned this bug, if possible. I already found and fixed the typo on my local build -- I would just need to get the change committed and reviewed. If anyone has advice on finding an appropriate reviewer, I'd appreciate it. (I've already taken a look at the new contributor guides, and I have a couple people in mind, but I'd hate to pester anyone with code that isn't their purview.)

Please assign me this bug. I have found out the source.

Assignee: nobody → eliotj12
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:eliotj12, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(smaug)
Flags: needinfo?(eliotj12)

I just landed the patch to fix a typo.

Flags: needinfo?(smaug)
Flags: needinfo?(eliotj12)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18c3f7df9914 Fixed typo in comment: extension.webextensions.remote to extensions.webextensions.remote. r=smaug DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: