Closed Bug 1843838 Opened 1 year ago Closed 1 year ago

Rename ScriptLoadRequest's IsReadyToRun method

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Bug 1843838 - Rename ScriptLoadRequest::IsReadyToRun to IsFinished since this returns true for cancelled requests r?smaug
48 bytes, text/x-phabricator-request
Details | Review

This method returns true when a request is complete, for both success and failure cases. This is confusing because the name suggests success only.

This came up in code review of bug 1842798.

Assignee: nobody → jcoppeard
Severity: -- → N/A
Priority: -- → P3
See Also: → 1842798
Depends on: 1842798
See Also: 1842798 →
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aab0f2ed3306 Rename ScriptLoadRequest::IsReadyToRun to IsFinished since this returns true for cancelled requests r=smaug

https://hg.mozilla.org/mozilla-central/rev/aab0f2ed3306

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: