Closed Bug 1844009 Opened 8 months ago Closed 7 months ago

Implement `type` field on response messages

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

task
Points:
1

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: jgraham, Assigned: whimboo)

References

()

Details

(Whiteboard: [webdriver:m8][webdriver:relnote])

Attachments

(1 file, 1 obsolete file)

https://github.com/w3c/webdriver-bidi/pull/484 added type fields to the top level messages so we can unambiguously distinguish responses / errors / events. We need to add these fields.

It's unclear if Chrome's implementation already supports it or now. As just I've asked jrandolf for feedback.

Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:triage] → [webdriver:backlog]
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m8]

Chrome has it already implemented so we can go ahead and include the type as well and enforce its existence in the tests.

Actually there are only a couple of lines that need an update. So it's basically a 1 point bug.

Points: 3 → 1

It looks like we cannot land this change yet given that chromedriver might require another release. I've asked for feedback:
https://github.com/w3c/webdriver-bidi/pull/484#issuecomment-1662855384

The status for chromedriver is still not clear given there is an issue right now with downloading the driver since the 115 release. As such I'm going to just land the Firefox patch on this bug, and will create a PR upstream for the Python client changes.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b083686a532
[webdriver-bidi] Add "type" field for response, error, and event to response payload. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Attachment #9346949 - Attachment is obsolete: true

Note that the Python WebDriver BiDi client change is going to land upstream via https://github.com/web-platform-tests/wpt/pull/41381.

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #10)

Note that the Python WebDriver BiDi client change is going to land upstream via https://github.com/web-platform-tests/wpt/pull/41381.

The PR got merged upstream. For landing on mozilla-central we have the wpt-sync bug 1847690.

Depends on: 1847690
Whiteboard: [webdriver:m8] → [webdriver:m8][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.