1844058 - "Filter rules containing this property" control is not accessible with keyboard alone

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-07-18 at 14.25.58.png

“Filter rules containing this property” control is not accessible with keyboard alone and a screen reader can only focus it in the browse/read all mode, the role is missing as well. NVDA cannot focus the element even in the browse mode and it splits the announcement in two strings: “clickable Filter rules containing” then (press Down Arrow) “this property”

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844058 - [devtools] Use <button> for Rules view filter property icon. r=#devtools-reviewers,#accessibility-frontend-reviewers.

Depends on D190262

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01b3c4cdab81
[devtools] Use <button> for Rules view filter property icon. r=devtools-reviewers,accessibility-frontend-reviewers,ayeddi,ochameau.

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/01b3c4cdab81

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

== Change summary for alert #40403 (as of Sun, 26 Nov 2023 17:08:12 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	damp custom.inspector.manyrules.deselectnode	windows10-64-shippable-qr	e10s fission stylo webrender	197.65 -> 210.21
6%	damp custom.inspector.manyrules.deselectnode	windows10-64-shippable-qr	e10s fission stylo webrender-sw	200.53 -> 211.96
5%	damp custom.inspector.manyrules.deselectnode	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	234.82 -> 247.60

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40403

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

"good" profile: https://share.firefox.dev/3t7VSFQ
"bad" profile: https://share.firefox.dev/3RtYK9q

(both on OSX though, and the regression did not seem to occur on osx)

Not obvious what's taking more time here, but this is a bit surprising that replacing a div with a button has such an impact
Emilio, would you know from the top of your head what could explain such regression?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Not off-hand, no. There's some overflow event there that happens in one profile but not other, maybe some styles on windows unexpectedly causing overflow and more JS to run?