1844092 - Stacktrace frame location can't be focused with keyboard only

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

When an error is thrown, the links to methods called are included in the trace but they are not focusable with keyboard (only “Learn more” link is focusable that sends a user to MDN), while mouse users could hover and activate these links. No role is provided for a screen reader as well, so its user would not know if they can, in fact, activate these links that are announced as static text.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nchevobbe, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844092 - [devtools] Make Stacktrace frame location keyboard accessible. r=#devtools-reviewers.

The frame elements already had the correct roles assigned,
but this was made completely useless because we had a
display: contents on them, which strips any accessibility role.
This was done for layout purpose that we now can do with
subgrids, so we update the component's CSS.
A webconsole test is added to ensure those stactkrace frames
can be navigated with the keyboard.

Depends on D190578

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f3e7fe297e2
[devtools] Make Stacktrace frame location keyboard accessible. r=devtools-reviewers,bomsy.

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_webconsole_context_menu_copy_message_with_framework_stacktrace.js

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c901d583200
[devtools] Make Stacktrace frame location keyboard accessible. r=devtools-reviewers,bomsy.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c901d583200