1844093 - Insufficient color contrast for some object text

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-07-18 at 15.37.38.png

Color contrast is not sufficient for the light gray text (such as output/return text like “undefined”, Filter placeholder, collapsed “<prototypes>” tree item): it’s 3.1:1 for the light gray text against white background while 4.5:1 or higher is expected

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nchevobbe, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844093 - [devtools] Tweak light theme `--theme-comment` to increase its contrast. r=#devtools-reviewers.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844093 - [devtools] Better contrast on eager evaluation results. r=#devtools-reviewers.

Don't override all colors to turn them (insufficiently contrasted) grey,
but apply a desaturate filter which should keep a good enought contrast.

Depends on D190549

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/706b32f4adf8
[devtools] Tweak light theme `--theme-comment` to increase its contrast. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/36ae8ef002f0
[devtools] Better contrast on eager evaluation results. r=devtools-reviewers,ochameau.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/706b32f4adf8
https://hg.mozilla.org/mozilla-central/rev/36ae8ef002f0