Closed
Bug 1844133
Opened 10 months ago
Closed 10 months ago
WebSocketConnection logs do not truncate properly huge payloads
Categories
(Remote Protocol :: Agent, defect, P1)
Remote Protocol
Agent
Tracking
(firefox117 fixed)
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
(Whiteboard: [webdriver:m8])
Attachments
(1 file)
Puppeteer enabled some tests from queryselector.spec which use callFunction with many arguments (huge node lists). This results in huge logs which crash the log parser.
|
Assignee | |
Comment 1•10 months ago
|
||
Puppeteer happens to send huge payloads as part of their test suite when using their $$eval API.
This is because they pass back and forth nodeLists for which all children are serialized by default.
This could be avoided by changing the serialization options (see https://github.com/puppeteer/puppeteer/issues/10582)
But without such a fix, we need to cap the size of the websocket logs, otherwise the logparser is unable to handle the
logs from the bidi puppeteer job.
|
|
Assignee | |
Updated•10 months ago
|
Points: --- → 1
Whiteboard: [webdriver:m8]
|
|
Assignee | |
Updated•10 months ago
|
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e17a38602bca [remote] WebSocketConnection logs should be truncated for huge objects r=webdriver-reviewers,Sasha
|
||
Comment 3•10 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•