1844133 - WebSocketConnection logs do not truncate properly huge payloads

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Puppeteer enabled some tests from queryselector.spec which use callFunction with many arguments (huge node lists). This results in huge logs which crash the log parser.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1844133 - [remote] WebSocketConnection logs should be truncated for huge objects

Puppeteer happens to send huge payloads as part of their test suite when using their $$eval API.
This is because they pass back and forth nodeLists for which all children are serialized by default.
This could be avoided by changing the serialization options (see https://github.com/puppeteer/puppeteer/issues/10582)

But without such a fix, we need to cap the size of the websocket logs, otherwise the logparser is unable to handle the
logs from the bidi puppeteer job.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e17a38602bca
[remote] WebSocketConnection logs should be truncated for huge objects r=webdriver-reviewers,Sasha

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e17a38602bca