Closed
Bug 1844266
Opened 10 months ago
Closed 10 months ago
Check enabling the feature instead of whether `RemoteSettings` client instance is changed after async processing
Categories
(Firefox :: Address Bar, task)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(1 file)
This is a follow-up bug of bug 1841295.
In the above bug, for PocketSuggestions feature, we started to check this.isEnabled after async processing in onRemoteSettingsSync instead of whether RemoteSettings client instance is changed. This is because the RemoteClient is single-tone, so the instance is basically unchanged. And one more reason is that even if it is disabled during asynchronous processing, not stop.
Thus, we should apply the same things to other features that provide suggestions.
|
Assignee | |
Updated•10 months ago
|
Summary: Check enabling the feature instead of whether `RemoteSettings` client instance is changed during async processing → Check enabling the feature instead of whether `RemoteSettings` client instance is changed after async processing
|
|
Assignee | |
Comment 1•10 months ago
|
||
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/178f56216f6d Check enabling the feature after async processing in onRemoteSettingsSync r=adw
|
||
Comment 3•10 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•