1844288 - "Learn more" hyperlink no longer available in the Picture-in-Picture developer warning dialog

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Attachment: Learn-more-no-longer-there.png

Found in

• Firefox Beta 116.0b7 (20230718185323)

Affected versions

• Firefox Nightly 117.0a1
• Firefox Beta 116.0b7

Affected platforms

• All

Steps to reproduce

1. Navigate to this link.
2. Open Picture-in-Picture using the URL bar PiP toggle.
3. Observe the developer warning dialog.

Expected result

• The "Learn more" hyperlink is available in the developer warning dialog according to specifications.

Actual result

• The "Learn more" hyperlink is not available in the developer warning dialog.

Regression range

• Mozregression pointed to the following: Bug 1840953
• Differential Revision: https://phabricator.services.mozilla.com/D183418

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:tgiles, since you are the author of the regressor, bug 1840953, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1844288 - Fix learn more link in disable PiP panel. r=#pip-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61701dc98fc7
Fix learn more link in disable PiP panel. r=pip-reviewers,kpatenio

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/61701dc98fc7

Comment 5

[Pascal Chevrel:pascalc]

Niklas, do you want to request uplift to our last beta? Thanks

Comment 6

[Niklas Baumgardner [:niklas]]

Comment on attachment 9344648 [details]
Bug 1844288 - Fix learn more link in disable PiP panel. r=#pip-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: The learn more link on the disable PiP panel was not showing so users couldn't visit the PiP support page. We want to make this page visible because we are releasing a new feature along with this panel in 116.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is a super simple fix of removing an attribute on the link so it will now show "Learn more"
• String changes made/needed: no
• Is Android affected?: No

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9344648 [details]
Bug 1844288 - Fix learn more link in disable PiP panel. r=#pip-reviewers

Approved for 116.0b8

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d43279a53412

Comment 9

[Dianna Smith [:diannaS]]

we will need a esr115 request as well if we still want to uplift bug 1840953

Comment 10

[Niklas Baumgardner [:niklas]]

This is pref'd off in 115 and won't be visible to users.
I can request uplift for ESR if we need it for bug 1840953 though.

What do you think?

Comment 11

[Dianna Smith [:diannaS]]

It's not needed if its pref'd off, thanks!

Comment 12

[Peter Magyari (Desktop QA)]

I have verified the fix using Nightly 117.0a1(20230720211923) and Beta 116.0b8(20230720200012) on Windows 10, MacOS 12 and Ubuntu 20.04.