1844344 - [win] Some context menu options are not correctly aligned

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: context_menu.gif

Found in

• 117.0a1 (2023-07-19)

Affected versions

• 117.0a1 (2023-07-19)

Tested platforms

• Affected platforms: Windows 10x64
• Unaffected platforms: macOS 12, Ubuntu 22.04

Steps to reproduce

1. R-click on a Toolbar or Bookmarks toolbar.
2. Observe the options.

Expected result

• All options are correctly aligned.

Actual result

• Some options are not correctly aligned like Menu Bar. I believe that those that have a checkmark and they are unchecked.

Regression range

• Last good revision: 1b8a2d934ea28f1bd4e58ff6dd153e76fd305a2c
  First bad revision: 2a02dfbea569f31a46429d24fee67b7f672c7f18
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1b8a2d934ea28f1bd4e58ff6dd153e76fd305a2c&tochange=2a02dfbea569f31a46429d24fee67b7f672c7f18
  Unfortunately I don’t know which bug is the regressor.

Additional notes

• Attached a screen recording.
• Note Show other bookmarks context menu option is not aligned correctly if unchecked as well.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, could you try to find a regression range using for example mozregression?

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #1)

:atrif, could you try to find a regression range using for example mozregression?

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1b8a2d934ea28f1bd4e58ff6dd153e76fd305a2c&tochange=2a02dfbea569f31a46429d24fee67b7f672c7f18

This is the regression range but unfortunately, I don't know the regressor.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Err, sorry, https://hg.mozilla.org/integration/autoland/rev/d53dc40a5390 should've landed as part of this bug.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

marking P1, since it's assigned and being actively worked

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Should be fixed by the patch above.

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 117.0a1 (2023-07-25) on Windows 10x64. The context menu options that have a checkmark available are correctly displayed.