1844364 - [PL][cocolita.pl] The autofill is not working for the expiry date field and it is also not saved in the CC manager

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, task)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-07-19_17h34_34.mp4

Found in

• 117.0a1

Affected versions

• 117.0a1

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 20

Preconditions

• browser.search.region to PL
• extensions.formautofill.creditCards.supportedCountries = PL
• have at least one CC already saved

Steps to reproduce

1. Reach the payment form on https://www.cocolita.pl
2. Click on the CC expiry date field
3. Click on the CC Number field and using the autofill feature, select any CC entry in order to autofill the fields.
4. Fill in manually with new CC info and submit the form

Expected result

• All the CC information should be stored to the CC manager.
• All the eligible CC fields should be autofilled.

Actual result

• The expiry date is not stored to the CC manager upon manually submitting the form.
• The autofill is not working for the expiry date field.

Regression range

• N/A

Additional notes

• Fathom Fox Sample

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:ailea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1844364 - Use isCreditCardField to determine whether the previous field is a credit card field r=#credential-management-reviewers

When we determine whether the previous field is a credit card field,
we use a hard-coded field name list, which doesn't include credit card
fields like "cc-given-name", "cc-family-name"

This patch fixes this issue by using "isCreditCardField" API.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/561b7f418a4d
Use isCreditCardField to determine whether the previous field is a credit card field r=credential-management-reviewers,sgalich

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in browser/extensions/formautofill/test/browser/heuristics/third_party/browser_QVC.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1ba3f32a547d54489f98bf83ff71302aaff7c4bc

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/heuristics/third_party/browser_QVC.js | fieldName should be equal

Comment 5

[Anca Soncutean, Desktop QA]

The same issue (having the same form) is reproducible on duka.com. I will let a ni on myself to take a look on this site as well, once this bug is fixed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6497c941182
Use isCreditCardField to determine whether the previous field is a credit card field r=credential-management-reviewers,sgalich

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a6497c941182

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 117.0a1 (2023-07-26). The expiry date is now autofilled correctly and it is also saved to the CC manager upon manually submitting the payment form. Verified on cocolita.pl and duka.com as well.