1844392 - [wpt-sync] Sync PR 41110 - [FedCM] Add tests for sec-fetch-{mode, site}

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41110 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41110
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Add tests for sec-fetch-{mode, site}

In the process, I found out that we set an incorrect originator --
it should be an opaque origin per the spec:
https://fedidcg.github.io/FedCM/#fetch-config-file

This difference matters because the tests actually connect to the
IDP on the same host, which would lead to a sec-fetch-site value
of same-site, when we actually always want it to be cross-site.

R=[e-mail]

Change-Id: If6b4f45ec948ef251ceed50077043005d537cb66
Reviewed-on: https://chromium-review.googlesource.com/4702024
WPT-Export-Revision: 86c9ea3e25376a2b2531929999707414155cc294

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecaab7a52c199cc6cf5f55aad6cb4a42effce577

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

CRASH : 1
TIMEOUT: 2
NOTRUN : 15

Chrome

FAIL : 1
TIMEOUT: 4
NOTRUN : 16

Safari

OK : 1
FAIL : 19
ERROR : 1

Links

GitHub PR Head
GitHub PR Base

Details

Crashes

• /credential-management/fedcm-userinfo.https.html [wpt.fyi]: CRASH

New Tests That Don't Pass

• /credential-management/fedcm-network-requests.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: ERROR)
  • Successfully obtaining token should resolve the promise.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
  • When there's a pending request, a second get call should be rejected. : NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Reject when provider list is empty: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Reject when configURL is missing: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Reject when configURL is invalid: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Reject when clientId is empty: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • nonce is not required in FederatedIdentityProvider.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Reject when clientId is missing: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test the abort signal: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Get after abort should work: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the promise is rejected if the manifest is not in the manifest list: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that promise is rejected if accounts endpoint redirects: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that token endpoint does not follow redirects: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test client_metadata request: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that service worker cannot observe fetches performed by FedCM API: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the returning account from the two accounts will be auto re-authenticated.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
• /credential-management/fedcm-userinfo.https.html [wpt.fyi]: CRASH (Chrome: TIMEOUT, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f17d4c2dcebe
[wpt PR 41110] - [FedCM] Add tests for sec-fetch-{mode, site}, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f17d4c2dcebe