1844403 - Perma tier2 WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::RTCRtpScriptTransformer'., /builds/worker/checkouts/gecko/dom/webidl/RTCTransformEvent.webidl line 15:22

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=423171969&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bfXm7nPfShW0VGycNHS3AA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-07-19T16:31:48.876Z] 16:31:48    ERROR -  Traceback (most recent call last):
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -    File "/builds/worker/fetches/python/lib/python3.8/runpy.py", line 194, in _run_module_as_main
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -      return _run_code(code, main_globals, None,
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -    File "/builds/worker/fetches/python/lib/python3.8/runpy.py", line 87, in _run_code
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -      exec(code, run_globals)
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/webidl.py", line 19, in <module>
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -      sys.exit(log_build_task(main, sys.argv[1:]))
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/util.py", line 16, in log_build_task
[task 2023-07-19T16:31:48.876Z] 16:31:48     INFO -      return f(*args, **kwargs)
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -      manager.generate_build_files()
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 288, in generate_build_files
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -      self._parse_webidl()
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 403, in _parse_webidl
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -      self._parser_results = parser.finish()
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 9074, in finish
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -      production.finish(self.globalScope())
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 1263, in finish
[task 2023-07-19T16:31:48.877Z] 16:31:48     INFO -      self.finishMembers(scope)
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 894, in finishMembers
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -      member.finish(scope)
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 5275, in finish
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -      t = self.type.complete(scope)
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 2695, in complete
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -      raise WebIDLError("Unresolved type '%s'." % self.name, [self.location])
[task 2023-07-19T16:31:48.878Z] 16:31:48    ERROR -  WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::RTCRtpScriptTransformer'., /builds/worker/checkouts/gecko/dom/webidl/RTCTransformEvent.webidl line 15:22
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -     readonly attribute RTCRtpScriptTransformer transformer;
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -                        ^
[task 2023-07-19T16:31:48.878Z] 16:31:48    ERROR -  gmake[4]: *** [Makefile:54: webidl.stub] Error 1
[task 2023-07-19T16:31:48.878Z] 16:31:48     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2023-07-19T16:31:48.879Z] 16:31:48     INFO -  gmake[4]: Target 'export' not remade because of errors.
[task 2023-07-19T16:31:48.879Z] 16:31:48    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:94: dom/bindings/export] Error 2
[task 2023-07-19T16:31:59.744Z] 16:31:59     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/ipc/ipdl'

Comment 1

[BugBot [:suhaib / :marco]]

:bwc, since you are the author of the regressor, bug 1631263, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Byron Campen [:bwc]]

I guess this is a build with media.peerconnection.enabled==false, do we just need to add a pref wrapper around the RTCTransformEventInit dictionary, or maybe around the |transform| attribute? Let me see...

Comment 3

[Byron Campen [:bwc]]

Hmm. While I do see places where we use Pref= on a dictionary attribute, we cannot do so on a required attribute, and we also cannot use Pref= on a dictionary. Is there no way to deal with the case where a dictionary type contains a required attribute that is some webidl interface that is wrapped in Pref=?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I can't recall on top of my head.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1631263

Comment 6

[Edgar Chen [:edgar]]

The error stems from the webidl parser not recognizing RTCRtpScriptTransformer, it should be a build configuration issue, (where RTCTransformEvent.webidl is included but RTCRtpScriptTransformer.webidl is not?), nothing to do with Pref= I think.

Would adding RTCTransformEvent.webidl to GENERATED_EVENTS_WEBIDL_FILES only when MOZ_WEBRTC is defined in dom/webidl/moz.build fix this?

Comment 7

[Intermittent Failures Robot]

20 failures in 645 pushes (0.031 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 16
• mozilla-central: 4

Platform and build breakdown:

• windows-mingw32: 20
  • all: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1844403&startday=2023-07-20&endday=2023-07-20&tree=all

Comment 8

[Petr Sumbera]

I see the same on Solaris:

 3:00.72 WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::RTCRtpScriptTransformer'., /builds/psumbera/mozilla-central-build/dom/webidl/RTCTransformEvent.webidl line 15:22
 3:00.72    readonly attribute RTCRtpScriptTransformer transformer;

Comment 9

[mac198442]

(In reply to Edgar Chen [:edgar] from comment #6)

The error stems from the webidl parser not recognizing RTCRtpScriptTransformer, it should be a build configuration issue, (where RTCTransformEvent.webidl is included but RTCRtpScriptTransformer.webidl is not?), nothing to do with Pref= I think.

Would adding RTCTransformEvent.webidl to GENERATED_EVENTS_WEBIDL_FILES only when MOZ_WEBRTC is defined in dom/webidl/moz.build fix this?

This DID NOT fix it for me.

Comment 10

[mac198442]

(In reply to mac198442 from comment #9)

(In reply to Edgar Chen [:edgar] from comment #6)

The error stems from the webidl parser not recognizing RTCRtpScriptTransformer, it should be a build configuration issue, (where RTCTransformEvent.webidl is included but RTCRtpScriptTransformer.webidl is not?), nothing to do with Pref= I think.

Would adding RTCTransformEvent.webidl to GENERATED_EVENTS_WEBIDL_FILES only when MOZ_WEBRTC is defined in dom/webidl/moz.build fix this?

This DID NOT fix it for me.

OOPs upon re-reading I think the idea was to move from the GENERATED files to only if webrtc is enabled

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=73136bb47aba995106fe5b66230539e799963d8f

Comment 12

[mac198442]

(In reply to Edgar Chen [:edgar] from comment #6)

The error stems from the webidl parser not recognizing RTCRtpScriptTransformer, it should be a build configuration issue, (where RTCTransformEvent.webidl is included but RTCRtpScriptTransformer.webidl is not?), nothing to do with Pref= I think.

Would adding RTCTransformEvent.webidl to GENERATED_EVENTS_WEBIDL_FILES only when MOZ_WEBRTC is defined in dom/webidl/moz.build fix this?

OK now after re-reading what you said, yes that fixes the issue for me.

Comment 13

[Byron Campen [:bwc]]

Attachment: Bug 1844403: Fix webidl build when MOZ_WEBRTC is not set. r?edgar

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e4ac6ed1acd
Fix webidl build when MOZ_WEBRTC is not set. r=edgar

Comment 15

[Intermittent Failures Robot]

38 failures in 691 pushes (0.055 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 26
• mozilla-central: 12

Platform and build breakdown:

• windows-mingw32: 38
  • all: 38

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1844403&startday=2023-07-21&endday=2023-07-21&tree=all

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7e4ac6ed1acd

Comment 17

[Intermittent Failures Robot]

68 failures in 3520 pushes (0.019 failures/push) were associated with this bug in the last 7 days.

This is the #9 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 52
• mozilla-central: 16

Platform and build breakdown:

• windows-mingw32: 68
  • all: 68

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1844403&startday=2023-07-17&endday=2023-07-23&tree=all