1844501 - CustomIdent::from_ident usage can usually be simplified to CustomIdent::parse

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zach Hoffman [:zrhoffman]]

Bug 1840477 adds CustomIdent::parse, which will usually be preferred over CustomIdent:from_ident as soon as as bug 1840477 lands.

One reason to still use CustomIdent::from_ident would be if the SourceLocation needs to be reused. Otherwise, a lot of the CustomIdent::from_ident usage can be simplified to CustomIdent::parse.

Comment 1

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1844501 - Replace some CustomIdent::from_ident usage with CustomIdent::parse r=#style

The remaining CustomIdent::from_ident usages do case-insensitive
comparisons (which should stay, since <custom-ident> is case-sensitive)
or reuse the token/ident instead of only creating a CustomIdent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb90638611ec
Replace some CustomIdent::from_ident usage with CustomIdent::parse r=emilio

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fb90638611ec