1844503 - This browser is not supported. on nicochannel.jp

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect, P2)

Description

[Alice0775 White]

Steps to reproduce:

1. Open https://nicochannel.jp/akb48-17ken/video/smUiezG3kjGCs2smvZr2ndNV w/o logged in.

Actual results:
このブラウザはサポートされていません。 in Japanese, This browser is not supported. in English. Unable to play video.

Expected results:
There is no such incompatibility.

Comment 1

[Calin Tanase]

Verified this issue and it's still reproducible on Firefox 124 with extensions.webcompat.perform_injections set to false.

Note: This issue has been investigated on https://github.com/webcompat/web-bugs/issues/124463

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1844503 - add a UA override for nicochannel-like sites, and update the related JS picture-in-picture API intervention; r?denschub

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3195e1620f15
add a UA override for nicochannel-like sites, and update the related JS picture-in-picture API intervention; r=denschub,webcompat-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3195e1620f15

Comment 5

[Thomas Wisniewski [:twisniewski]]

This should have been left open, pardon the bugspam.

Comment 6

[[:FaySmash]]

For little background information, affected are all sites which use the sheeta website software, developed by DWANGO, the company behind niconico and nicochannel+. There are many more sites affected than the ones already added to the useragent overwrite list and their number is increasing.
Today I discovered, that the fixes currently applied (UA fix + window.PictureInPictureWindow injection) aren't enough anymore, the sheeta sites stopped working again. Although I couldn't figure out what changed yet.

Comment 7

[[:FaySmash]]

I've tried for hours but couldn't figure out what changed in the sheeta react apps, that it stopped working (also tested with latest nightly).

Comment 8

[Thomas Wisniewski [:twisniewski]]

I've also just put some time into this, but it's unclear what they're using to detect the UA. It seems unrelated to navigator.userAgent, navigator.userAgentData, or sec-ch-ua type headers, or other stuff which Chrome Mask spoofs, as I've tested with all of those enabled (including navigator.userAgentData.getHighEntropyValues()) to no avail. It also doesn't seem to be ETP, as disabling it doesn't help.

The only real clue I have so far is that Chrome manages to get to this code in their VideoDescription JS, while Firefox does not:

    e.useEffect( () => {
        l(se({
            contentCode: d,
            type: H.VOD
        })).then(ne).then( () => {
            t("ALLOWED")
        }
        ).catch(g => {
            t(Pe(g))
        }
        )
    }

However, it's unclear why Firefox isn't getting there, as the stack traces are pretty cryptic. I'll have to take another look when I have more time.

Comment 9

[Thomas Wisniewski [:twisniewski]]

Thanks to :emilio for noticing that they have slightly changed their detection for the picture-in-picture API!

I'll update our intervention for these sites in bug 1948817 while adding qlover.jp to the list.

Comment 10

[[:FaySmash]]

Here is an issue where more affected sites and detection methods are listed, together with the suggestion to use this Google search to find all sites utilizing sheeta.

Comment 11

[Thomas Wisniewski [:twisniewski]]

Thanks! I'll investigate those links ASAP.

Comment 12

[Thomas Wisniewski [:twisniewski]]

Just FYI, the fix for the list of sites we were already fixing has landed in time for Firefox 137 in bug 1948817. I'll investigate adding more sites to the list ASAP.

Comment 13

[[:FaySmash]]

I can confirm, that by installing the latest [e-mail] version, the issue has been fixed! 🥳
To combat not yet supported sites, I previously used an userscript as a workaround:

// ==UserScript==
// @name PictureInPictureWindow compatibility Fix
// @namespace Violentmonkey Scripts
// @grant none
// ==/UserScript==
window.PictureInPictureWindow = class PictureInPictureWindow{}

This was based on this webcompat code:

Object.defineProperty(window.wrappedJSObject, "PictureInPictureWindow", {
  value: exportFunction(function () {
    return class {};
  }, window),
 });

Now I wanted to integrate the new fix as well, but I couldn't figure out how to convert this webcompat code:

Object.defineProperty(Document.wrappedJSObject.prototype, "pictureInPictureElement", {
   get: exportFunction(function () {
     return null;
   }, window),
   set: exportFunction(function () {}, window),
 });

Into a userscript (I've tried adding this before, to no avail Document.prototype.pictureInPictureElement = function () {})

Maybe someone can help me out, but for now all sites I'm mostly using are working again 👌

Comment 14

[Thomas Wisniewski [:twisniewski]]

:FaySmash, I suspect that this should suffice:

Document.prototype.pictureInPictureElement = null;

It's hard to tell if spoofing these APIs on all sites might cause issues, though. Sites might add extra (and non-functioning) picture in picture buttons on their video players, for instance.

Comment 15

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1844503 - add 16 more sites to our nicochannel intervention; r?denschub

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4cb3e75dcde
add 16 more sites to our nicochannel intervention; r=denschub,webcompat-reviewers

Comment 17

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e4cb3e75dcde

Comment 18

[Thomas Wisniewski [:twisniewski]]

Reopening. This should have been left open for tracking purposes.

Comment 19

[Thomas Wisniewski [:twisniewski]]

It seems as though they are no longer blocking Firefox, and don't have the issue with not detecting picture-in-picture APIs, so we should be able to remove our intervention.

Comment 20

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1844503, 1948817 - remove webcompat interventions for nicochannel sites; r?denschub

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a6d0d114f88
1948817 - remove webcompat interventions for nicochannel sites; r=denschub,webcompat-reviewers

Comment 22

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3a6d0d114f88

Comment 23

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:twisniewski, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 24

[Calin Tanase]

Verified, the issue no longer reproduces with the RC build (regardless of the intervention status).

Tested with:

Browser / Version: Firefox 138.0-candidate build 1
Operating System: Windows 10