1844520 - Mark AutoEnterOOMUnsafeRegion::crash has a static function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[[:sergesanspaille]]

Otherwise -ftrivial-auto-var-init always initialize the empty class one byte because the object has its address taken by a method that does not need it.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1844520 - Forward AutoEnterOOMUnsafeRegion::crash to a static implementation r=nbp

Interestingly, this removes a reference to this which in turns unlocks
a few compiler optimization.

More specifically, -ftrivial-auto-var-init always initialize the empty
class with one byte because the object has its address taken by a method
that does not need it.

This patch removes the need for that class to have an address.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dd2a590f9b8
Forward AutoEnterOOMUnsafeRegion::crash to a static implementation r=nbp

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1dd2a590f9b8